Fix PR link generation in new-change and bug in render command (#2767)

- Generate correct /pull/ URLs for PR references instead of /issues/
- Fix template field name from 'pull request:' to 'pull requests:'
- Fix version parsing check in render command

Author: yasmewad

.changes/next-release/bugfix-3462fce24080c851a7e66263b70c5280721f6767.json

@@ -0,0 +1,7 @@
+{
+  "type": "bugfix",
+  "description": "Fix PR link generation in new-change and render command",
+  "pull_requests": [
+    "[#2767](https://github.com/smithy-lang/smithy/pull/2767)"
+  ]
+}

.changes/smithy_changelog/__init__.py

@@ -141,7 +141,7 @@ def from_path(cls, path: Path) -> Self:
         The file name is expected to be in the form `major.minor.patch.extention`.
         """
         parts = path.name.split(".", 3)
-        if len(parts) != 3:
+        if len(parts) != 4:
             raise Exception(
                 f"Invalid version. Expected `major.minor.patch.extension` "
                 f"(e.g. `1.2.3.json`), but found: {path.name}"
@@ -224,7 +224,9 @@ def write(self, file: Path | None = None) -> str:
 
         :returns: The JSON representation of the release as a string.
         """
-        contents = json.dumps(asdict(self), indent=2, default=str) + "\n"
+        data = asdict(self)
+        data["version"] = str(self.version)
+        contents = json.dumps(data, indent=2, default=str) + "\n"
         if file is not None:
             file.write_text(contents)
         return contents

.changes/smithy_changelog/new.py

@@ -23,9 +23,9 @@
 type: {change_type}
 
 # (Optional)
-# A link to the GitHub pull request that implments the feature. You can use GitHub
+# A link to the GitHub pull request that implements the feature. You can use GitHub
 # sytle references, which will automatically be replaced with the correct link.
-pull request: {pull_requests}
+pull requests: {pull_requests}
 
 # A brief description of the change. You can use GitHub style references to issues such
 # as "fixes #489", "smithy-lang/smithy#100", etc. These will get automatically replaced
@@ -116,16 +116,20 @@ def get_values_from_editor(
 
 
 def replace_issue_references(change: Change, repo_name: str):
-    def linkify(match: re.Match[str]):
+    def linkify_issue(match: re.Match[str]):
         number = match.group()[1:]
         return f"[{match.group()}](https://github.com/{repo_name}/issues/{number})"
 
-    new_description = re.sub(r"#\d+", linkify, change.description)
+    def linkify_pr(match: re.Match[str]):
+        number = match.group()[1:]
+        return f"[{match.group()}](https://github.com/{repo_name}/pull/{number})"
+
+    new_description = re.sub(r"#\d+", linkify_issue, change.description)
     change.description = new_description
 
     if change.pull_requests:
         change.pull_requests = [
-            re.sub(r"#\d+", linkify, pr) for pr in change.pull_requests
+            re.sub(r"#\d+", linkify_pr, pr) for pr in change.pull_requests
         ]