Skip to content

Commit e469de6

Browse files
authored
Re-enable Sign op int64 test for QNN CPU test (microsoft#18734)
### Description Re-enable Sign op int64 test for QNN CPU test
1 parent 3d8af6e commit e469de6

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

onnxruntime/test/providers/cpu/math/sign_test.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,7 @@ TEST(MathOpTest, Sign_int64) {
140140
std::vector<int64_t> output;
141141
TestImpl<int64_t>(input.cbegin(), input.cend(), std::back_inserter(output));
142142
test.AddOutput<int64_t>("output", input_dims, output);
143-
// TODO: QNN execute error, need further investigation
144-
test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kOpenVINOExecutionProvider, kQnnExecutionProvider});
143+
test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kOpenVINOExecutionProvider});
145144
}
146145

147146
TEST(MathOpTest, Sign_float) {

onnxruntime/test/providers/cpu/nn/conv_op_test.cc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,6 @@ void TestConvOp(const ConvOpAndTestAttributes& attributes,
6363
// QNN SDK 2.10.0 has a bug that breaks support for dynamic bias inputs.
6464
excluded_providers.insert(kQnnExecutionProvider);
6565

66-
// TODO: Enable QNN EP when bug with QNN SDK 2.10.0 is fixed:
67-
/*
68-
// QNN have issue with dynamic weight, auto pad with SAME_UPPER, SAME_LOWER
69-
if (!weight_is_initializer || attributes.auto_pad == "SAME_UPPER" || attributes.auto_pad == "SAME_LOWER") {
70-
excluded_providers.insert(kQnnExecutionProvider);
71-
}
72-
*/
73-
7466
test.Run(expect_result, err_str, excluded_providers);
7567
}
7668

0 commit comments

Comments
 (0)