Fix AddToCart and RemoveFromCart types (close #926)

Author: Paul Boocock

libraries/tracker-core/src/core.ts

@@ -1049,13 +1049,13 @@ export interface AddToCartEvent {
   /** A Product Stock Keeping Unit (SKU) */
   sku: string;
   /** The number added to the cart */
-  quantity: string;
+  quantity: number;
   /** The name of the product */
   name?: string;
   /** The category of the product */
   category?: string;
   /** The price of the product */
-  unitPrice?: string;
+  unitPrice?: number;
   /** The currency of the product */
   currency?: string;
 }
@@ -1094,13 +1094,13 @@ export interface RemoveFromCartEvent {
   /** A Product Stock Keeping Unit (SKU) */
   sku: string;
   /** The number removed from the cart */
-  quantity: string;
+  quantity: number;
   /** The name of the product */
   name?: string;
   /** The category of the product */
   category?: string;
   /** The price of the product */
-  unitPrice?: string;
+  unitPrice?: number;
   /** The currency of the product */
   currency?: string;
 }

libraries/tracker-core/test/core.ts

@@ -393,8 +393,8 @@ test('should track a social interaction', (t) => {
 });
 test('should track an add-to-cart event', (t) => {
   const sku = '4q345';
-  const unitPrice = '17';
-  const quantity = '2';
+  const unitPrice = 17.0;
+  const quantity = 2;
   const name = 'red shoes';
   const category = 'clothing';
   const currency = 'USD';
@@ -420,8 +420,8 @@ test('should track an add-to-cart event', (t) => {
 });
 test('should track a remove-from-cart event', (t) => {
   const sku = '4q345';
-  const unitPrice = '17';
-  const quantity = '2';
+  const unitPrice = 17.0;
+  const quantity = 2;
   const name = 'red shoes';
   const category = 'clothing';
   const currency = 'USD';
@@ -845,7 +845,7 @@ test('should run plugin before and after track callbacks on each track event', (
       })
     ),
     tracker.track(buildPageView({ pageUrl: url, pageTitle: str, referrer: url })),
-    tracker.track(buildAddToCart({ category: str, name: str, quantity: str, sku: str, unitPrice: str })),
+    tracker.track(buildAddToCart({ category: str, name: str, quantity: num, sku: str, unitPrice: num })),
     tracker.track(buildScreenView({ id: str, name: str })),
     tracker.track(buildSiteSearch({ filters, pageResults: num, terms: arr, totalResults: num })),
     tracker.track(buildStructEvent({ category: str, action: str })),
@@ -875,7 +875,7 @@ test('should run plugin before and after track callbacks on each track event', (
       })
     ),
     tracker.track(buildFormSubmission({ elements: [], formClasses: [], formId: str })),
-    tracker.track(buildRemoveFromCart({ category: str, name: str, quantity: str, sku: str, unitPrice: str })),
+    tracker.track(buildRemoveFromCart({ category: str, name: str, quantity: num, sku: str, unitPrice: num })),
     tracker.track(buildConsentGranted({ id: str, version: str }).event),
     tracker.track(buildConsentWithdrawn({ all: true }).event),
     tracker.track(