Allow 0x0 viewport in browser context to avoid schema validation errors (#1365)

matus-tomlein · matus-tomlein · commit 740f9a3d222c · 2024-10-28T11:17:56.000+01:00
diff --git a/common/changes/@snowplow/browser-tracker-core/issue-allow_zero_viewport_2024-10-28-09-31.json b/common/changes/@snowplow/browser-tracker-core/issue-allow_zero_viewport_2024-10-28-09-31.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@snowplow/browser-tracker-core",
+      "comment": "Allow 0x0 viewport in browser context to avoid schema validation errors",
+      "type": "none"
+    }
+  ],
+  "packageName": "@snowplow/browser-tracker-core"
+}
diff --git a/libraries/browser-tracker-core/src/helpers/browser_props.ts b/libraries/browser-tracker-core/src/helpers/browser_props.ts
@@ -103,11 +103,7 @@ function detectViewport() {
     height = e['clientHeight'];
   }
 
-  if (width >= 0 && height >= 0) {
-    return width + DIMENSION_SEPARATOR + height;
-  } else {
-    return null;
-  }
+  return Math.max(0, width) + DIMENSION_SEPARATOR + Math.max(0, height);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -103,11 +103,7 @@ function detectViewport() {`
`103`	`103`	`height = e['clientHeight'];`
`104`	`104`	`}`
`105`	`105`
`106`		`- if (width >= 0 && height >= 0) {`
`107`		`- return width + DIMENSION_SEPARATOR + height;`
`108`		`- } else {`
`109`		`- return null;`
`110`		`- }`
	`106`	`+ return Math.max(0, width) + DIMENSION_SEPARATOR + Math.max(0, height);`
`111`	`107`	`}`
`112`	`108`
`113`	`109`	`/**`