Skip to content

Commit 4c9a8b8

Browse files
authored
refactor(experimental): Add Nonce and Token JSON parsed account types (#2031)
* Move Blockhash from transactions to rpc-types * Move assertIsBlockhash from transactions to rpc-types * Add nonce JSON parsed account type * Add remaining JSON parsed token accounts
1 parent cee6f23 commit 4c9a8b8

40 files changed

+335
-172
lines changed

packages/compat/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,15 @@
6666
},
6767
"dependencies": {
6868
"@solana/functional": "workspace:*",
69-
"@solana/keys": "workspace:*",
7069
"@solana/instructions": "workspace:*",
70+
"@solana/keys": "workspace:*",
7171
"@solana/transactions": "workspace:*"
7272
},
7373
"devDependencies": {
7474
"@solana/addresses": "workspace:*",
7575
"@solana/eslint-config-solana": "^1.0.2",
7676
"@solana/keys": "workspace:*",
77+
"@solana/rpc-types": "workspace:*",
7778
"@solana/web3.js": "workspace:*",
7879
"@swc/jest": "^0.2.29",
7980
"@types/jest": "^29.5.11",

packages/compat/src/transaction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import { pipe } from '@solana/functional';
33
import type { IAccountMeta, IInstruction } from '@solana/instructions';
44
import { AccountRole } from '@solana/instructions';
55
import type { SignatureBytes } from '@solana/keys';
6+
import type { Blockhash } from '@solana/rpc-types';
67
import {
78
appendTransactionInstruction,
8-
type Blockhash,
99
createTransaction,
1010
type IDurableNonceTransaction,
1111
isAdvanceNonceAccountInstruction,

packages/library-legacy-sham/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
},
7373
"devDependencies": {
7474
"@solana/eslint-config-solana": "^1.0.2",
75+
"@solana/rpc-types": "workspace:*",
7576
"@solana/web3.js-legacy": "workspace:../library-legacy",
7677
"@swc/jest": "^0.2.29",
7778
"@types/jest": "^29.5.11",
@@ -80,13 +81,13 @@
8081
"@typescript-eslint/parser": "^6.3.0",
8182
"agadoo": "^3.0.0",
8283
"build-scripts": "workspace:*",
84+
"eslint": "^8.45.0",
8385
"eslint-plugin-jest": "^27.4.2",
8486
"eslint-plugin-sort-keys-fix": "^1.1.2",
85-
"eslint": "^8.45.0",
87+
"jest": "^29.7.0",
8688
"jest-environment-jsdom": "^29.7.0",
8789
"jest-runner-eslint": "^2.1.2",
8890
"jest-runner-prettier": "^1.0.0",
89-
"jest": "^29.7.0",
9091
"prettier": "^3.1",
9192
"test-config": "workspace:*",
9293
"tsconfig": "workspace:*",

packages/library-legacy-sham/src/transaction.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
import { Address } from '@solana/addresses';
2+
import { assertIsBlockhash, type Blockhash } from '@solana/rpc-types';
23
import {
3-
assertIsBlockhash,
44
assertTransactionIsFullySigned,
55
BaseTransaction,
6-
Blockhash,
76
CompilableTransaction,
87
createTransaction,
98
getTransactionDecoder,

packages/library/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,4 +107,4 @@
107107
}
108108
]
109109
}
110-
}
110+
}

packages/library/src/__tests__/decode-transaction-test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import { FetchAccountsConfig, fetchJsonParsedAccounts } from '@solana/accounts';
22
import type { Address } from '@solana/addresses';
33
import { GetMultipleAccountsApi } from '@solana/rpc-core';
44
import { Rpc } from '@solana/rpc-transport';
5-
import { type Blockhash, decompileTransaction, getCompiledTransactionDecoder } from '@solana/transactions';
5+
import type { Blockhash } from '@solana/rpc-types';
6+
import { decompileTransaction, getCompiledTransactionDecoder } from '@solana/transactions';
67
import { CompiledTransaction } from '@solana/transactions/dist/types/compile-transaction';
78

89
import { LamportsUnsafeBeyond2Pow53Minus1 } from '..';

packages/library/src/__tests__/transaction-confirmation-test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { Address } from '@solana/addresses';
22
import { AccountRole, ReadonlySignerAccount, WritableAccount } from '@solana/instructions';
33
import { Signature, SignatureBytes } from '@solana/keys';
4-
import { Blockhash, IDurableNonceTransaction, Nonce } from '@solana/transactions';
4+
import type { Blockhash } from '@solana/rpc-types';
5+
import { IDurableNonceTransaction, Nonce } from '@solana/transactions';
56

67
import {
78
waitForDurableNonceTransactionConfirmation,

packages/rpc-core/src/rpc-methods/__tests__/get-fee-for-message-test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { fixEncoder } from '@solana/codecs-core';
22
import { getBase58Encoder, getBase64Decoder } from '@solana/codecs-strings';
33
import { createHttpTransport, createJsonRpc, type Rpc, type SolanaJsonRpcErrorCode } from '@solana/rpc-transport';
4-
import { Commitment } from '@solana/rpc-types';
5-
import { Blockhash, SerializedMessageBytesBase64 } from '@solana/transactions';
4+
import type { Blockhash, Commitment } from '@solana/rpc-types';
5+
import { SerializedMessageBytesBase64 } from '@solana/transactions';
66
import fetchMock from 'jest-fetch-mock-fork';
77

88
import { createSolanaRpcApi, GetFeeForMessageApi, GetLatestBlockhashApi } from '../index';

packages/rpc-core/src/rpc-methods/__tests__/is-blockhash-valid-test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { createHttpTransport, createJsonRpc, type Rpc } from '@solana/rpc-transport';
2-
import { Commitment } from '@solana/rpc-types';
3-
import { Blockhash } from '@solana/transactions';
2+
import type { Blockhash, Commitment } from '@solana/rpc-types';
43
import fetchMock from 'jest-fetch-mock-fork';
54

65
import { createSolanaRpcApi, IsBlockhashValidApi } from '../index';

packages/rpc-core/src/rpc-methods/__typetests__/get-block-type-test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@ import type {
44
Base58EncodedBytes,
55
Base58EncodedDataResponse,
66
Base64EncodedDataResponse,
7+
Blockhash,
78
LamportsUnsafeBeyond2Pow53Minus1,
89
} from '@solana/rpc-types';
9-
import { Blockhash, TransactionVersion } from '@solana/transactions';
10+
import { TransactionVersion } from '@solana/transactions';
1011

1112
import { TransactionError } from '../../transaction-error';
1213
import { GetBlockApi } from '..';

0 commit comments

Comments
 (0)