[build] Fix compilation deadlock issue #24104
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clounix-sw
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
longwu-clounix
force-pushed
the
Fix-compilation-dead-lock
branch
from
13776e1 to
dde4f1b
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
longwu-clounix
force-pushed
the
Fix-compilation-dead-lock
branch
from
dde4f1b to
47d3f6f
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
longwu-clounix
force-pushed
the
Fix-compilation-dead-lock
branch
from
47d3f6f to
5dc14fa
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it If the previous compilation exited abnormally during the installation process, the subsequent compilation process(ex: make target/xxx.bin SONIC_BUILD_JOBS=4) may enter a deadlock state because the file lock(`$(DEBS_PATH)/dpkg_lock`) may not be deleted. How I did it Try to deleted the file lock before starting compilation. How to verify it The compilation always be OK though the previous compilation exited abnormally during the installation process. Signed-off-by: Long Wu <[email protected]>
longwu-clounix
force-pushed
the
Fix-compilation-dead-lock
branch
from
5dc14fa to
7e7c5fa
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@xumia @qiluo-msft could you please review this PR? Thank you~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
If the previous compilation exited abnormally during the installation process, the subsequent compilation process(ex: make target/xxx.bin SONIC_BUILD_JOBS=8) may enter a deadlock state because the file lock(
$(DEBS_PATH)/dpkg_lock) may not be deleted.Work item tracking
How I did it
Deleted the file lock before starting installation.
How to verify it
The compilation always be OK though the previous compilation exited abnormally during the installation process.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)