Automatically start web interface upon container start. #2198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web interface now automatically starts when starting container
|
Thanks for the greag proposal, @7677865466! But with the web mode as default, it won't be possible to run Maigret in the default mode just by specifying a username, while this should be a frequent Docker use case. Maybe we should make separate Dockerfiles for that? Or are there other options? |
|
I think separate docker files will work. Could also add a new image on docker or Github container registry that allows for quicker deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple edit, but this makes the web interface now automatically start when starting container. Is currently using port 5000 but perhaps we could add an environment variable that provides the port to the container.