rename flagname to treatment

Author: ZamoraEmmanuel

src/__tests__/nodeSuites/provider.spec.js

@@ -114,7 +114,7 @@ export default async function(assert) {
     t.equal(calls.count, 1, "Split track called once");
     t.deepEqual(
       calls.args,
-      ["u1", "user", "view", 0, {}],
+      ["u1", "user", "view", undefined, {}],
       "called with key, trafficType, eventName, 0, {}"
     );
     t.end();

src/lib/js-split-provider.ts

@@ -54,17 +54,17 @@ export class OpenFeatureSplitProvider implements Provider {
       flagKey,
       this.transformContext(context)
     );
-    const flagName = details.value.toLowerCase();
+    const treatment = details.value.toLowerCase();
 
-    if ( flagName === "on" || flagName === "true" ) {
+    if ( treatment === "on" || treatment === "true" ) {
       return { ...details, value: true };
     }
 
-    if ( flagName === "off" || flagName === "false" ) {
+    if ( treatment === "off" || treatment === "false" ) {
       return { ...details, value: false };
     }
 
-    throw new ParseError(`Invalid boolean value for ${flagName}`);
+    throw new ParseError(`Invalid boolean value for ${treatment}`);
   }
 
   async resolveStringEvaluation(
@@ -156,7 +156,7 @@ export class OpenFeatureSplitProvider implements Provider {
     if (trafficType == null || trafficType === "")
       throw new ParseError("Missing trafficType variable, required to track");
 
-    let value = 0;
+    let value;
     let properties: SplitIO.Properties = {};
     if (details != null) {
       if (details.value != null) {