Update tests

Author: ZamoraEmmanuel

src/__tests__/nodeSuites/client.spec.js

@@ -1,19 +1,31 @@
 /* eslint-disable jest/no-conditional-expect */
 import { OpenFeatureSplitProvider } from '../../lib/js-split-provider';
-import { getLocalHostSplitClient } from '../testUtils';
+import { getLocalHostSplitClient, getSplitFactory } from '../testUtils';
 
 import { OpenFeature } from '@openfeature/server-sdk';
 
-describe('client tests', () => {
+const cases = [
+  [
+    'openfeature client tests mode: splitClient',
+    () => ({ splitClient: getLocalHostSplitClient()}),
+    
+  ],
+  [
+    'openfeature client tests mode: splitFactory',
+    getSplitFactory
+  ],
+];
+
+describe.each(cases)('%s', (label, getOptions) => {
 
   let client;
-  let splitClient;
   let provider;
+  let options;
 
   beforeEach(() => {
-    splitClient = getLocalHostSplitClient();
-    provider = new OpenFeatureSplitProvider({ splitClient });
 
+    options = getOptions();
+    provider = new OpenFeatureSplitProvider(options);
     OpenFeature.setProvider(provider);
 
     client = OpenFeature.getClient('test');
@@ -22,9 +34,8 @@ describe('client tests', () => {
     };
     client.setContext(evaluationContext);
   });
-  afterEach(() => {
-    splitClient.destroy();
-    provider = undefined;
+  afterEach(async () => {
+    await OpenFeature.close();
   });
 
   test('use default test', async () => {
@@ -206,13 +217,13 @@ describe('client tests', () => {
   });
 
   test('track: without value', async () => {
-    const trackSpy = jest.spyOn(splitClient, 'track');
+    const trackSpy = jest.spyOn(options.splitClient ? options.splitClient : options.client(), 'track');
     await client.track('my-event', { targetingKey: 'u1', trafficType: 'user' }, { properties: { prop1: 'value1' } });
     expect(trackSpy).toHaveBeenCalledWith('u1', 'user', 'my-event', undefined, {  prop1: 'value1' });
   });
 
   test('track: with value', async () => {
-    const trackSpy = jest.spyOn(splitClient, 'track');
+    const trackSpy = jest.spyOn(options.splitClient ? options.splitClient : options.client(), 'track');
     await client.track('my-event', { targetingKey: 'u1', trafficType: 'user' }, { value: 9.99, properties: { prop1: 'value1' } });
     expect(trackSpy).toHaveBeenCalledWith('u1', 'user', 'my-event', 9.99, {  prop1: 'value1' });
   });

src/__tests__/nodeSuites/provider.spec.js

@@ -4,26 +4,29 @@ import { OpenFeatureSplitProvider } from '../../lib/js-split-provider';
 
 const cases = [
   [
-    'Localhost',
-    { splitClient: getLocalHostSplitClient()},
+    'provider tests mode: splitClient',
+    () => ({ splitClient: getLocalHostSplitClient()}),
 
   ],
   [
-    'Factory',
-    getSplitFactory()
+    'provider tests mode: splitFactory',
+    getSplitFactory
   ],
 ];
 
 describe.each(cases)('%s', (label, getOptions) => {
 
   let provider;
+  let options;
 
-  beforeEach(async () => {
-    provider = new OpenFeatureSplitProvider(getOptions);
+  beforeEach(() => {
+    options = getOptions();
+    provider = new OpenFeatureSplitProvider(options);
   });
 
   afterEach(async () => {
     jest.clearAllMocks()
+    await provider.onClose();
   });
 
   test('evaluate Boolean null/empty test', async () => {
@@ -219,14 +222,14 @@ describe.each(cases)('%s', (label, getOptions) => {
   });
 
   test('track: ok without details', async () => {
-    const trackSpy = jest.spyOn(getOptions.splitClient ? getOptions.splitClient : getOptions.client(), 'track');
+    const trackSpy = jest.spyOn(options.splitClient ? options.splitClient : options.client(), 'track');
     await provider.track('view', { targetingKey: 'u1', trafficType: 'user' }, null);
     expect(trackSpy).toHaveBeenCalledTimes(1);
     expect(trackSpy).toHaveBeenCalledWith('u1', 'user', 'view', undefined, {});
   });
 
   test('track: ok with details', async () => {
-    const trackSpy = jest.spyOn(getOptions.splitClient ? getOptions.splitClient : getOptions.client(), 'track');
+    const trackSpy = jest.spyOn(options.splitClient ? options.splitClient : options.client(), 'track');
     await provider.track(
       'purchase',
       { targetingKey: 'u1', trafficType: 'user' },

src/__tests__/testUtils/index.js

@@ -95,7 +95,6 @@ const config = {
       authorizationKey: 'localhost'
     },
     features: './split.yaml',
-    debug: 'DEBUG'
   }
 /**
  * get a Split client in localhost mode for testing purposes