ci: updating component

Author: harshilgajera-crest

pytest_splunk_addon_ui_smartx/components/controls/checkboxgroup.py

@@ -17,7 +17,6 @@
 
 from ..base_component import Selector
 from .base_control import BaseControl
-from .button import Button
 from .checkbox import Checkbox
 from .textbox import TextBox
 
@@ -65,34 +64,19 @@ def is_group_expanded(self, group_name: str) -> bool:
             == "true"
         )
 
-    def select_checkbox_and_set_value(
-        self, checkbox_name: str, checkbox_value: str
-    ) -> None:
-        """
-        Selects a checkbox and sets a value for the checkbox.
-
-        Args:
-            checkbox_name (str): The name of the checkbox to select.
-            checkbox_value (str): The value to set for the checkbox.
-        """
-        Checkbox(
+    def get_checkbox(self, checkbox_name: str) -> Checkbox:
+        return Checkbox(
             self.browser,
             Selector(
                 by=By.XPATH,
                 select=self.elements.get("container").select
                 + f"//div[@data-test-field='{checkbox_name}']/parent::div",
             ),
-        ).check()
-        TextBox(
-            self.browser,
-            Selector(
-                by=By.XPATH,
-                select=self.elements.get("container").select
-                + f"//div[@data-test-field='{checkbox_name}' and @data-test='number']",
-            ),
-        ).set_value(checkbox_value)
+        )
 
-    def select(self, group_name: str, checkbox_name: str, checkbox_value: str) -> None:
+    def select_checkbox_and_set_value(
+        self, group_name: str, checkbox_name: str, checkbox_value: str = None
+    ) -> None:
         """
         Expands a group and selects a checkbox, then sets the specified value.
 
@@ -102,9 +86,9 @@ def select(self, group_name: str, checkbox_name: str, checkbox_value: str) -> No
             checkbox_value (str): The value to set for the checkbox.
         """
         self.expand_group(group_name)
-        self.select_checkbox_and_set_value(
-            checkbox_name=checkbox_name, checkbox_value=checkbox_value
-        )
+        self.get_checkbox(checkbox_name).check()
+        if checkbox_value:
+            self.get_textbox(checkbox_name).set_value(checkbox_value)
 
     def deselect(self, group_name: str, checkbox_name: str) -> None:
         """
@@ -115,18 +99,21 @@ def deselect(self, group_name: str, checkbox_name: str) -> None:
             checkbox_name (str): The name of the checkbox to deselect.
         """
         self.expand_group(group_name)
-        Checkbox(
+        self.get_checkbox(checkbox_name).uncheck()
+
+    def get_textbox(self, checkbox_name: str) -> TextBox:
+        return TextBox(
             self.browser,
             Selector(
                 by=By.XPATH,
                 select=self.elements.get("container").select
-                + f"//div[@data-test-field='{checkbox_name}']/parent::div",
+                + f"//div[@data-test-field='{checkbox_name}' and @data-test='number']",
             ),
-        ).uncheck()
+        )
 
-    def get_checkbox_value(self, group_name: str, checkbox_name: str) -> str:
+    def get_checkbox_text_value(self, group_name: str, checkbox_name: str) -> str:
         """
-        Expands a group and retrieves the value of the specified checkbox.
+        Expands a group and retrieves the text value of the specified checkbox.
 
         Args:
             group_name (str): The name of the group to expand.
@@ -136,14 +123,7 @@ def get_checkbox_value(self, group_name: str, checkbox_name: str) -> str:
             str: The value of the checkbox.
         """
         self.expand_group(group_name)
-        return TextBox(
-            self.browser,
-            Selector(
-                by=By.XPATH,
-                select=self.elements.get("container").select
-                + f"//div[@data-test-field='{checkbox_name}' and @data-test='number']",
-            ),
-        ).get_value()
+        return self.get_textbox(checkbox_name).get_value()
 
     def expand_group(self, group_name: str) -> None:
         """

tests/ui/test_splunk_ta_example_addon_input_2.py

@@ -531,8 +531,12 @@ def test_example_input_two_add_backend_validation(
         input_page.entity2.example_multiple_select.select("Option Two")
         input_page.entity2.index.select("main")
         input_page.entity2.interval.set_value("90")
-        input_page.entity2.checkboxgroup.select("EC2", "ec2_instances", "100")
-        input_page.entity2.checkboxgroup.select("ELB", "classic_load_balancers", "100")
+        input_page.entity2.checkboxgroup.select_checkbox_and_set_value(
+            "EC2", "ec2_instances", "100"
+        )
+        input_page.entity2.checkboxgroup.select_checkbox_and_set_value(
+            "ELB", "classic_load_balancers", "100"
+        )
         input_page.entity2.example_account.select("test_input")
         input_page.entity2.query_start_date.set_value("2020-12-11T20:00:32.000z")
         self.assert_util(input_page.entity2.save, True)
@@ -616,7 +620,15 @@ def test_example_input_two_edit_backend_validation(
         input_page.entity2.query_start_date.set_value("2020-20-20T20:20:20.000z")
         input_page.entity2.checkboxgroup.deselect("EC2", "ec2_instances")
         input_page.entity2.checkboxgroup.deselect("ELB", "classic_load_balancers")
-        input_page.entity2.checkboxgroup.select("VPC", "vpcs", "1000")
+        self.assert_util(
+            input_page.entity2.checkboxgroup.get_textbox(
+                "ELB", "classic_load_balancers"
+            ).is_editable(),
+            False,
+        )
+        input_page.entity2.checkboxgroup.select_checkbox_and_set_value(
+            "VPC", "vpcs", "1000"
+        )
         self.assert_util(input_page.entity2.save, True)
         input_page.table.wait_for_rows_to_appear(1)
         value_to_test = {