Skip to content

Commit 923282d

Browse files
chore: address review comments
1 parent 6a3a82b commit 923282d

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

.github/workflows/reusable-build-test-release.yml

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -206,24 +206,22 @@ jobs:
206206
echo "Docs-only changes detected. No tests will be executed."
207207
else
208208
echo "checking available test types."
209-
declare -a AVAILABLE_EXECUTION_TESTS
209+
declare -a TESTS_TO_CONSIDER_FOR_EXECUTION
210210
211211
while read -r TEST_BASE_NAME; do
212212
if [[ -d "tests/$TEST_BASE_NAME" ]]; then
213-
AVAILABLE_EXECUTION_TESTS+=("execute_$TEST_BASE_NAME")
213+
TESTS_TO_CONSIDER_FOR_EXECUTION+=("execute_$TEST_BASE_NAME")
214214
echo "$TEST_BASE_NAME::true"
215215
fi
216216
done < <(find tests -type d -maxdepth 1 -mindepth 1 | sed 's|^tests/||g')
217217
218-
while read -r TEST_BASE_NAME; do
219-
if [[ -d "package/default/data/$TEST_BASE_NAME" ]]; then
220-
AVAILABLE_EXECUTION_TESTS+=("execute_$TEST_BASE_NAME")
221-
echo "$TEST_BASE_NAME::true"
222-
fi
223-
done < <(find package/default/data -type d -name "spl2" -maxdepth 1 -mindepth 1 | sed 's|^package/default/data/||g')
218+
if [[ -d "package/default/data/spl2" ]]; then
219+
TESTS_TO_CONSIDER_FOR_EXECUTION+=("execute_spl2")
220+
echo "spl2::true"
221+
fi
224222
225223
found_unit_test=false
226-
for test_name in "${AVAILABLE_EXECUTION_TESTS[@]}"; do
224+
for test_name in "${TESTS_TO_CONSIDER_FOR_EXECUTION[@]}"; do
227225
if [[ "$test_name" == "execute_unit" ]]; then
228226
found_unit_test=true
229227
break
@@ -233,8 +231,6 @@ jobs:
233231
EXECUTION_FLAGS["execute_unit"]="true"
234232
fi
235233
236-
declare -a TESTS_TO_CONSIDER_FOR_EXECUTION=("${AVAILABLE_EXECUTION_TESTS[@]}")
237-
238234
case "${{ github.event_name }}" in
239235
"pull_request")
240236
labels=$(echo '${{ toJSON(github.event.pull_request.labels) }}' | jq -r '.[] | .name')

0 commit comments

Comments
 (0)