Skip to content
This repository was archived by the owner on Jan 17, 2019. It is now read-only.

Commit 2794fb7

Browse files
committed
NS_enums are no longer unsigned across the framework
1 parent 6347ec8 commit 2794fb7

File tree

8 files changed

+8
-8
lines changed

8 files changed

+8
-8
lines changed

include/HubFramework/HUBActionTrigger.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#import <Foundation/Foundation.h>
2323

2424
/// Enum describing various reasons that can cause an action to be triggered
25-
typedef NS_ENUM(NSUInteger, HUBActionTrigger) {
25+
typedef NS_ENUM(NSInteger, HUBActionTrigger) {
2626
/// The action was triggered by that a component was selected
2727
HUBActionTriggerSelection,
2828
/// The action was triggered manually by a component

include/HubFramework/HUBComponentLayoutManager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ NS_ASSUME_NONNULL_BEGIN
3030
* A content edge is where the rendering of content "stops", such as at the screen edge or when
3131
* an area covered by a navigation bar begins. Content edges have a 1:1 mapping to content insets.
3232
*/
33-
typedef NS_ENUM(NSUInteger, HUBComponentLayoutContentEdge) {
33+
typedef NS_ENUM(NSInteger, HUBComponentLayoutContentEdge) {
3434
/// The top content edge, usually where a navigation bar begins
3535
HUBComponentLayoutContentEdgeTop,
3636
/// The right content edge, usually at the screen edge

include/HubFramework/HUBComponentType.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#import <Foundation/Foundation.h>
2323

2424
/// Enum describing various types of components used in the Hub Framework
25-
typedef NS_ENUM(NSUInteger, HUBComponentType) {
25+
typedef NS_ENUM(NSInteger, HUBComponentType) {
2626
/// Type of components used in the header of a view
2727
HUBComponentTypeHeader,
2828
/// Type of components used in the body of a view

include/HubFramework/HUBComponentWithFocusState.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#import "HUBComponent.h"
2323

2424
/// Enum defining various focus states that a component can be in
25-
typedef NS_ENUM(NSUInteger, HUBComponentFocusState) {
25+
typedef NS_ENUM(NSInteger, HUBComponentFocusState) {
2626
/// The component is not in focus
2727
HUBComponentFocusStateNone,
2828
/// The component is in focus, either programmatically or by the user

include/HubFramework/HUBComponentWithSelectionState.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#import "HUBComponent.h"
2323

2424
/// Enum defining various selection states that a component can be in
25-
typedef NS_ENUM(NSUInteger, HUBComponentSelectionState) {
25+
typedef NS_ENUM(NSInteger, HUBComponentSelectionState) {
2626
/// The component is neither selected or highlighted
2727
HUBComponentSelectionStateNone,
2828
/// The component is currently highlighted through a user interaction

include/HubFramework/HUBConnectivityState.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#import <Foundation/Foundation.h>
2323

2424
/// Enum describing various connectivity states that an application can be in
25-
typedef NS_ENUM(NSUInteger, HUBConnectivityState) {
25+
typedef NS_ENUM(NSInteger, HUBConnectivityState) {
2626
/// The application is currently online and connected to the Internet
2727
HUBConnectivityStateOnline,
2828
/// The application is currently offline and not connected to the Internet

sources/HUBDefaultConnectivityStateResolver.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ - (void)dealloc
7878
- (HUBConnectivityState)resolveConnectivityState
7979
{
8080
if (self.connectivityState != nil) {
81-
return [self.connectivityState unsignedIntegerValue];
81+
return [self.connectivityState integerValue];
8282
}
8383

8484
SCNetworkReachabilityFlags reachabilityFlags;

sources/HUBViewModelDiff.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ static inline HUBDiffPoint HUBDiffPointMake(NSInteger x, NSInteger y) {
181181
return (HUBDiffPoint){ .x = x, .y = y };
182182
}
183183

184-
typedef NS_ENUM(NSUInteger, HUBDiffStepType) {
184+
typedef NS_ENUM(NSInteger, HUBDiffStepType) {
185185
HUBDiffStepTypeInsert,
186186
HUBDiffStepTypeDelete,
187187
HUBDiffStepTypeMatchPoint

0 commit comments

Comments
 (0)