Skip to content

Commit 5c9d6a6

Browse files
committed
fix wrong test example
Signed-off-by: moonyougnCHAE <[email protected]>
1 parent 5c173c1 commit 5c9d6a6

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

spring-kafka-docs/src/main/antora/modules/ROOT/pages/testing.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ The following example configuration creates topics called `cat` and `hat` with f
149149
public class MyTests {
150150
151151
@ClassRule
152-
private static EmbeddedKafkaRule embeddedKafka = new EmbeddedKafkaRule(1, false, 5, "cat", "hat");
152+
public static EmbeddedKafkaRule embeddedKafka = new EmbeddedKafkaRule(1, false, 5, "cat", "hat");
153153
154154
@Test
155155
public void test() {

spring-kafka/src/main/java/org/springframework/kafka/support/converter/BatchMessagingMessageConverter.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -169,17 +169,18 @@ public Message<?> toMessage(List<ConsumerRecord<?, ?>> records, @Nullable Acknow
169169
new KafkaMessageHeaders(this.generateMessageId, this.generateTimestamp);
170170

171171
Map<String, Object> rawHeaders = kafkaMessageHeaders.getRawHeaders();
172-
List<Object> payloads = new ArrayList<>();
173-
List<Object> keys = new ArrayList<>();
174-
List<String> topics = new ArrayList<>();
175-
List<Integer> partitions = new ArrayList<>();
176-
List<Long> offsets = new ArrayList<>();
177-
List<String> timestampTypes = new ArrayList<>();
178-
List<Long> timestamps = new ArrayList<>();
179-
List<Map<String, Object>> convertedHeaders = new ArrayList<>();
180-
List<Headers> natives = new ArrayList<>();
181-
List<ConsumerRecord<?, ?>> raws = new ArrayList<>();
182-
List<ConversionException> conversionFailures = new ArrayList<>();
172+
int batchSize = records.size();
173+
List<Object> payloads = new ArrayList<>(batchSize);
174+
List<Object> keys = new ArrayList<>(batchSize);
175+
List<String> topics = new ArrayList<>(batchSize);
176+
List<Integer> partitions = new ArrayList<>(batchSize);
177+
List<Long> offsets = new ArrayList<>(batchSize);
178+
List<String> timestampTypes = new ArrayList<>(batchSize);
179+
List<Long> timestamps = new ArrayList<>(batchSize);
180+
List<Map<String, Object>> convertedHeaders = new ArrayList<>(batchSize);
181+
List<Headers> natives = new ArrayList<>(batchSize);
182+
List<ConsumerRecord<?, ?>> raws = new ArrayList<>(batchSize);
183+
List<ConversionException> conversionFailures = new ArrayList<>(batchSize);
183184

184185
addToRawHeaders(rawHeaders, convertedHeaders, natives, raws, conversionFailures);
185186
commonHeaders(acknowledgment, consumer, rawHeaders, keys, topics, partitions, offsets, timestampTypes,

0 commit comments

Comments
 (0)