Skip to content

Commit 61d73fe

Browse files
change getIfAvailable
1 parent a76988e commit 61d73fe

File tree

9 files changed

+16
-14
lines changed

9 files changed

+16
-14
lines changed

config/src/main/java/org/springframework/security/config/annotation/method/configuration/GlobalMethodSecurityConfiguration.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import org.springframework.beans.BeansException;
2828
import org.springframework.beans.factory.BeanFactory;
2929
import org.springframework.beans.factory.BeanFactoryAware;
30-
import org.springframework.beans.factory.NoSuchBeanDefinitionException;
3130
import org.springframework.beans.factory.SmartInitializingSingleton;
3231
import org.springframework.beans.factory.annotation.Autowired;
3332
import org.springframework.beans.factory.config.BeanDefinition;

config/src/main/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ private SecurityExpressionHandler<FilterInvocation> getExpressionHandler(H http)
168168
if (context != null) {
169169
context.getBeanProvider(RoleHierarchy.class).ifUnique(defaultHandler::setRoleHierarchy);
170170
context.getBeanProvider(GrantedAuthorityDefaults.class)
171-
.ifUnique(grantedAuthorityDefaults -> defaultHandler
171+
.ifUnique((grantedAuthorityDefaults) -> defaultHandler
172172
.setDefaultRolePrefix(grantedAuthorityDefaults.getRolePrefix()));
173173
context.getBeanProvider(PermissionEvaluator.class).ifUnique(defaultHandler::setPermissionEvaluator);
174174
}

config/src/main/java/org/springframework/security/config/annotation/web/configurers/ServletApiConfigurer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public void configure(H http) {
9494
ApplicationContext context = http.getSharedObject(ApplicationContext.class);
9595
if (context != null) {
9696
context.getBeanProvider(GrantedAuthorityDefaults.class)
97-
.ifUnique(grantedAuthorityDefaults -> this.securityContextRequestFilter
97+
.ifUnique((grantedAuthorityDefaults) -> this.securityContextRequestFilter
9898
.setRolePrefix(grantedAuthorityDefaults.getRolePrefix()));
9999
this.securityContextRequestFilter.setSecurityContextHolderStrategy(getSecurityContextHolderStrategy());
100100
}

config/src/main/java/org/springframework/security/config/annotation/web/configurers/saml2/Saml2LogoutConfigurer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ private <C> C getBeanOrNull(Class<C> clazz) {
337337
if (this.context == null) {
338338
return null;
339339
}
340-
return this.context.getBeanProvider(clazz).getIfUnique();
340+
return this.context.getBeanProvider(clazz).getIfAvailable();
341341
}
342342

343343
/**

config/src/main/java/org/springframework/security/config/annotation/web/configurers/saml2/Saml2MetadataConfigurer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ private <C> C getBeanOrNull(Class<C> clazz) {
174174
if (this.context == null) {
175175
return null;
176176
}
177-
return this.context.getBeanProvider(clazz).getIfUnique();
177+
return this.context.getBeanProvider(clazz).getIfAvailable();
178178
}
179179

180180
}

config/src/main/java/org/springframework/security/config/http/GrantedAuthorityDefaultsParserUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ abstract static class AbstractGrantedAuthorityDefaultsBeanFactory implements App
5151
@Override
5252
public final void setApplicationContext(ApplicationContext applicationContext) throws BeansException {
5353
applicationContext.getBeanProvider(GrantedAuthorityDefaults.class)
54-
.ifUnique(grantedAuthorityDefaults -> this.rolePrefix = grantedAuthorityDefaults.getRolePrefix());
54+
.ifUnique((grantedAuthorityDefaults) -> this.rolePrefix = grantedAuthorityDefaults.getRolePrefix());
5555
}
5656

5757
abstract Object getBean();

config/src/main/java/org/springframework/security/config/method/GlobalMethodSecurityBeanDefinitionParser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ abstract static class AbstractGrantedAuthorityDefaultsBeanFactory implements App
485485
@Override
486486
public final void setApplicationContext(ApplicationContext applicationContext) throws BeansException {
487487
applicationContext.getBeanProvider(GrantedAuthorityDefaults.class)
488-
.ifUnique(grantedAuthorityDefaults -> this.rolePrefix = grantedAuthorityDefaults.getRolePrefix());
488+
.ifUnique((grantedAuthorityDefaults) -> this.rolePrefix = grantedAuthorityDefaults.getRolePrefix());
489489
}
490490

491491
}

config/src/main/java/org/springframework/security/config/method/MethodSecurityBeanDefinitionParser.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ public Class<?> getObjectType() {
309309
@Override
310310
public void setApplicationContext(ApplicationContext applicationContext) throws BeansException {
311311
applicationContext.getBeanProvider(GrantedAuthorityDefaults.class)
312-
.ifUnique(grantedAuthorityDefaults -> this.expressionHandler
312+
.ifUnique((grantedAuthorityDefaults) -> this.expressionHandler
313313
.setDefaultRolePrefix(grantedAuthorityDefaults.getRolePrefix()));
314314
}
315315

@@ -345,7 +345,7 @@ public Class<?> getObjectType() {
345345
@Override
346346
public void setApplicationContext(ApplicationContext applicationContext) throws BeansException {
347347
applicationContext.getBeanProvider(GrantedAuthorityDefaults.class)
348-
.ifUnique(grantedAuthorityDefaults -> this.manager
348+
.ifUnique((grantedAuthorityDefaults) -> this.manager
349349
.setRolePrefix(grantedAuthorityDefaults.getRolePrefix()));
350350
}
351351

config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@
285285
* @author Parikshit Dutta
286286
* @author Ankur Pathak
287287
* @author Alexey Nesterov
288-
* @author Ngoc Nhan
289288
* @since 5.0
290289
*/
291290
public class ServerHttpSecurity {
@@ -1735,22 +1734,26 @@ private <T> T getBean(Class<T> beanClass) {
17351734
}
17361735

17371736
private <T> T getBeanOrDefault(Class<T> beanClass, T defaultInstance) {
1738-
if (this.context == null) {
1737+
T bean = getBeanOrNull(beanClass);
1738+
if (bean == null) {
17391739
return defaultInstance;
17401740
}
1741-
return this.context.getBeanProvider(beanClass).getIfUnique(() -> defaultInstance);
1741+
return bean;
17421742
}
17431743

17441744
private <T> T getBeanOrNull(Class<T> beanClass) {
17451745
return getBeanOrNull(ResolvableType.forClass(beanClass));
17461746
}
17471747

1748-
@SuppressWarnings("unchecked")
17491748
private <T> T getBeanOrNull(ResolvableType type) {
17501749
if (this.context == null) {
17511750
return null;
17521751
}
1753-
return (T) this.context.getBeanProvider(type).getIfUnique();
1752+
String[] names = this.context.getBeanNamesForType(type);
1753+
if (names.length == 1) {
1754+
return (T) this.context.getBean(names[0]);
1755+
}
1756+
return null;
17541757
}
17551758

17561759
private <T> T getBeanOrNull(String beanName, Class<T> requiredClass) {

0 commit comments

Comments
 (0)