Skip to content

Commit f7f1e95

Browse files
razvansbernauer
andauthored
Apply suggestions from code review
Co-authored-by: Sebastian Bernauer <[email protected]>
1 parent 68809f8 commit f7f1e95

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

rust/operator-binary/src/config/fault_tolerant_execution.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -462,8 +462,6 @@ mod tests {
462462
reference: test-s3-connection
463463
maxErrorRetries: 5
464464
uploadPartSize: 10Mi
465-
iamRole: arn:aws:iam::123456789012:role/TrinoRole
466-
externalId: external-id-123
467465
"#});
468466

469467
let fte_config =

rust/operator-binary/src/controller.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1550,6 +1550,8 @@ fn shared_spooling_secret_name(trino: &v1alpha1::TrinoCluster) -> String {
15501550
format!("{}-spooling-secret", trino.name_any())
15511551
}
15521552

1553+
// TODO: Maybe switch to something non-openssl.
1554+
// See https://github.com/stackabletech/airflow-operator/pull/686#discussion_r2348354468 (which is currently under discussion)
15531555
fn get_random_base64(byte_size: usize) -> String {
15541556
let mut buf: Vec<u8> = vec![0; byte_size];
15551557
openssl::rand::rand_bytes(&mut buf).unwrap();

0 commit comments

Comments
 (0)