feat: add custom certificate #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rubenhoenle merged 30 commits into stackitcloud:main from matheuspolitano:mp/cdn-custom-domain-add-byoc

Sep 18, 2025

Contributor

matheuspolitano commented Sep 4, 2025 •

edited

Loading

Description

https://jira.schwarz/browse/STACKITCDN-1000

Implement Certificate to CDN custom domain

relates to #1234

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see examples/ directory)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Acceptance tests got implemented or updated (see e.g. here)
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

matheuspolitano requested a review from a team as a code owner

September 4, 2025 18:55

matheuspolitano changed the title ~~add custom certificate~~ feat: add custom certificate

marceljk reviewed

View reviewed changes

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/datasource.go Outdated Show resolved Hide resolved

marceljk reviewed

View reviewed changes

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource.go Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

rubenhoenle assigned marceljk

marceljk reviewed

View reviewed changes

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/cdn_acc_test.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/cdn_acc_test.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/datasource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource_test.go Show resolved Hide resolved

marceljk reviewed

View reviewed changes

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

marceljk reviewed

View reviewed changes

stackit/internal/services/cdn/customdomain/datasource.go Outdated Show resolved Hide resolved

marceljk reviewed

View reviewed changes

stackit/internal/services/cdn/customdomain/datasource_test.go Outdated Show resolved Hide resolved

marceljk reviewed

View reviewed changes

examples/resources/stackit_cdn_custom_domain/resource.tf Outdated Show resolved Hide resolved

marceljk reviewed

View reviewed changes

stackit/internal/services/cdn/customdomain/datasource.go Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/datasource.go Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource.go Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource.go Outdated Show resolved Hide resolved

stackit/internal/services/cdn/customdomain/resource_test.go Show resolved Hide resolved

marceljk approved these changes

View reviewed changes

rubenhoenle mentioned this pull request

CDN - Add Geofencing #994

Closed

8 tasks

rubenhoenle approved these changes

View reviewed changes

Matheus Politano and others added 16 commits

September 18, 2025 19:22


          add custom certificate

e7fbde2


          remove print


          fix error test

1c384c7


          Adjust certificate

b6500fb


          format resource

1dd0bec


          Update stackit/internal/services/cdn/customdomain/resource.go

c0d4810

Co-authored-by: Marcel Jacek <[email protected]>


          Update stackit/internal/services/cdn/customdomain/resource.go

1a02807

Co-authored-by: Marcel Jacek <[email protected]>


          Update stackit/internal/services/cdn/customdomain/resource.go

2507af2

Co-authored-by: Marcel Jacek <[email protected]>


          Update stackit/internal/services/cdn/customdomain/datasource.go

5d7c83b

Co-authored-by: Marcel Jacek <[email protected]>


          improve code

8c60b29


          Update stackit/internal/services/cdn/customdomain/resource.go

eceae8f

Co-authored-by: Marcel Jacek <[email protected]>


          add update certificate

aba7625


          remove dialogs

65a8aa6


          Update stackit/internal/services/cdn/customdomain/resource_test.go

f8f3ecc

Co-authored-by: Marcel Jacek <[email protected]>


          apply code suggestion

9aa84b6


          remove error

d598198

Matheus Politano and others added 14 commits

September 18, 2025 19:22


          solve pr issues

80fe6d7


          add random domain name

4805b1d


          fix make doc and lint

e35e70e


          Update stackit/internal/services/cdn/customdomain/resource.go

5fa5d13

Co-authored-by: Marcel Jacek <[email protected]>


          fix rename function and move to the top var

3743e47


          remove useless var

5771d3a


          Update stackit/internal/services/cdn/customdomain/resource_test.go

ebd7886

Co-authored-by: Marcel Jacek <[email protected]>


          fix the test

882b9ab


          add message when the certificate and private_key is undedined

10fc1a8


          Update examples/resources/stackit_cdn_custom_domain/resource.tf

eb0f8f3

Co-authored-by: Marcel Jacek <[email protected]>


          add datasource

94ee425


          final code adjustment

e8b6f46


          add checj to custom domain

f6edb73


          update doc

e6e6032

rubenhoenle force-pushed the mp/cdn-custom-domain-add-byoc branch from 636450c to e6e6032 Compare

September 18, 2025 17:22

rubenhoenle merged commit df0f152 into stackitcloud:main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet