Skip to content

Conversation

@amirejaz
Copy link
Contributor

This PR updates the GoReleaser signing configuration to be compatible with cosign v3.

Why

Cosign v3 requires the --bundle flag when using --output-signature or keyless signing. Without it, the release workflow fails with:

@amirejaz amirejaz requested a review from Copilot October 17, 2025 15:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates GoReleaser configuration to ensure compatibility with cosign v3 by adding the required --bundle flag to the signing configuration. This prevents release workflow failures that occur when using cosign v3 without proper bundle configuration.

  • Added --bundle=${signature} flag to cosign signing arguments for v3 compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@amirejaz amirejaz requested a review from ChrisJBurns October 17, 2025 15:45
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.46%. Comparing base (dc11d30) to head (3bc9a8b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2246   +/-   ##
=======================================
  Coverage   55.45%   55.46%           
=======================================
  Files         285      285           
  Lines       26770    26770           
=======================================
+ Hits        14845    14847    +2     
+ Misses      10562    10560    -2     
  Partials     1363     1363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amirejaz amirejaz merged commit dc27be4 into main Nov 6, 2025
28 checks passed
@amirejaz amirejaz deleted the cosign_bundle_signing branch November 6, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants