Skip to content

Conversation

@Itay-Tsabary-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Itay-Tsabary-Starkware commented Nov 10, 2025

Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/apollo_dashboard/src/dashboard.rs line 93 at r1 (raw file):

            Unit::PercentUnit => "percentunit",
            Unit::MB => "decmbytes",
            Unit::Microseconds => "µs",

Where did you bring this character from? It's not ASCII...

Code quote:

"µs"

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_dashboard_add_microseconds_units_to_tokio_panels branch from 5c6c185 to b678c73 Compare November 11, 2025 17:50
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_dashboard_format_from_x_panel_titles branch from f4a52e5 to 1603a68 Compare November 11, 2025 17:50
Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @matanl-starkware)


crates/apollo_dashboard/src/dashboard.rs line 93 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Where did you bring this character from? It's not ASCII...

This is the required char by grafana to mark the units as microseconds.
I wrote it's utf code and then cursor just swapped it in.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_dashboard_add_microseconds_units_to_tokio_panels branch from b678c73 to a295281 Compare November 12, 2025 13:52
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_dashboard_format_from_x_panel_titles branch from 1603a68 to 02e0705 Compare November 12, 2025 13:52
Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matanl-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants