-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_dashboard: add microseconds units to tokio panels #10064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11-10-apollo_dashboard_format_from_x_panel_titles
Are you sure you want to change the base?
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
911d75f to
fdb5b18
Compare
b2163ab to
81678e6
Compare
fdb5b18 to
5c6c185
Compare
81678e6 to
f4a52e5
Compare
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanl-starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/apollo_dashboard/src/dashboard.rs line 93 at r1 (raw file):
Unit::PercentUnit => "percentunit", Unit::MB => "decmbytes", Unit::Microseconds => "µs",
Where did you bring this character from? It's not ASCII...
Code quote:
"µs"5c6c185 to
b678c73
Compare
f4a52e5 to
1603a68
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @matanl-starkware)
crates/apollo_dashboard/src/dashboard.rs line 93 at r1 (raw file):
Previously, matanl-starkware (Matan Lior) wrote…
Where did you bring this character from? It's not ASCII...
This is the required char by grafana to mark the units as microseconds.
I wrote it's utf code and then cursor just swapped it in.
b678c73 to
a295281
Compare
1603a68 to
02e0705
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matanl-starkware)

No description provided.