apollo_proc_macros: timed test macros #10065
Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
victorkstarkware
force-pushed
the
11-10-apollo_proc_macros_timed_test_macros
branch
2 times, most recently
from
396bc8b to
907bb53
Compare
victorkstarkware
force-pushed
the
11-10-apollo_proc_macros_timed_test_macros
branch
12 times, most recently
from
069e68d to
c0e0c10
Compare
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion
crates/apollo_proc_macros_tests/tests/timed_test.rs line 61 at r1 (raw file):
tokio::time::sleep(Duration::from_millis(20)).await; assert!(value > 0); }
Could you please add tests that are expected to fail (look for the #[should_panic] annotation) such that:
- some fail on the actual test content
- some fail on timeout
Code quote:
#[timed_rstest_tokio(150)]
#[case(1)]
#[case(2)]
async fn test_rstest_async_custom_limit(#[case] value: u32) {
tokio::time::sleep(Duration::from_millis(20)).await;
assert!(value > 0);
}
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @victorkstarkware)
crates/apollo_proc_macros/src/lib.rs line 610 at r1 (raw file):
Ok(_) => { let elapsed = start.elapsed(); let elapsed_ms = elapsed.as_millis() as u64;
Why is this conversion needed?
Code quote:
let elapsed_ms = elapsed.as_millis() as u64;
Itay-Tsabary-Starkware
left a comment
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @victorkstarkware)
crates/apollo_proc_macros/src/lib.rs line 622 at r1 (raw file):
Err(_) => { let elapsed = start.elapsed(); let elapsed_ms = elapsed.as_millis() as u64;
These two lines appear in both branches, please unify them (by calling them before the match statement)
Code quote:
let elapsed = start.elapsed();
let elapsed_ms = elapsed.as_millis() as u64;
victorkstarkware
force-pushed
the
11-10-apollo_proc_macros_timed_test_macros
branch
from
c0e0c10 to
1abf29e
Compare
victorkstarkware
left a comment
victorkstarkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/apollo_proc_macros/src/lib.rs line 610 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Why is this conversion needed?
time limit constant is given in ms
crates/apollo_proc_macros/src/lib.rs line 622 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
These two lines appear in both branches, please unify them (by calling them before the
matchstatement)
Done.
crates/apollo_proc_macros_tests/tests/timed_test.rs line 61 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Could you please add tests that are expected to fail (look for the
#[should_panic]annotation) such that:
- some fail on the actual test content
- some fail on timeout
Done.
victorkstarkware
force-pushed
the
11-10-apollo_proc_macros_timed_test_macros
branch
6 times, most recently
from
358f47a to
bd78fe0
Compare
victorkstarkware
force-pushed
the
11-10-apollo_proc_macros_timed_test_macros
branch
from
bd78fe0 to
5b7e27e
Compare
victorkstarkware
force-pushed
the
11-10-apollo_proc_macros_timed_test_macros
branch
from
5b7e27e to
1f1d01a
Compare
No description provided.