starknet_patricia_storage,starknet_committer_cli: add optional Column Families in RocksDbStorage

[rotem-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[rotem-starkware]

• starknet_patricia_storage,starknet_committer_cli: add optional Column Families in RocksDbStorage #10086 👈 (View in Graphite)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp)

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 39 at r1 (raw file):

const MAX_BACKGROUND_JOBS: i32 = 8;

const BYTE: usize = 8;

I don't think you need this const, you can use u8::BITS when you need it

Code quote:

const BYTE: usize = 8;

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 124 at r1 (raw file):

    pub fn get_column_family(&self, key: &DbKey) -> &ColumnFamily {
        if self.column_families {
            let last_byte = key.0.last().unwrap();

we should allow writing to null keys without panic (i.e. a DB key of &[])

Suggestion:

let last_byte = key.0.last().unwrap_or(0u8);

---

crates/starknet_committer_cli/src/main.rs line 105 at r1 (raw file):

    /// If true, the storage will use 256 column families. Only relevant for Rocksdb.
    #[clap(long, action=ArgAction::SetTrue)]
    use_column_families: bool,

heads up: if you rebase over this it will look nicer :)
non-blocking of course

Code quote:

    /// If true, the storage will use 256 column families. Only relevant for Rocksdb.
    #[clap(long, action=ArgAction::SetTrue)]
    use_column_families: bool,

[dorimedini-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp and @rotem-starkware)

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 112 at r1 (raw file):

        let cfs = if column_families {
            (0..1 << BYTE)
                .map(|i| ColumnFamilyDescriptor::new(format!("{i}"), Options::default()))

columns must be strings? not bytes/integers?

Code quote:

ColumnFamilyDescriptor::new(