exclude files too #1585
Open
exclude files too #1585
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillem Bonet <[email protected]>
|
hi, I fixed the failing test (I think) |
|
hey @sdghchj , can someone approve the workflow? thanks! |
|
Hey folks @easonlin404 @ubogdan, could you please take a look to this related to #879 by any chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Allows excluding files as described in the
--excludeflag help. Right now only directories can be excluded.Relation issue
related to #879
Additional context
Files will be excluded in the
getAllGoFileInfofunction while directories continue to be excluded during the directory walk. This is why in the test I added there are 4 files instead of 3.