Skip to content

Commit 44b2d71

Browse files
committed
[lldb] Remove unnecessary use of computeExtendedNominal
This doesn't appear to be necessary anymore, we're attempting to reconstruct a VarDecl from a previous evaluation, but AFAICT that would imply that we've already correctly resolved the type. But more importantly, this wouldn't be correct anyway since it wouldn't handle cases where resolving the extension relies on other extensions being bound for e.g nested types.
1 parent 664ae58 commit 44b2d71

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -846,15 +846,6 @@ GetPatternBindingForVarDecl(swift::VarDecl *var_decl,
846846
swift::NamedPattern *named_pattern =
847847
swift::NamedPattern::createImplicit(ast_context, var_decl);
848848

849-
// Since lldb does not call bindExtensions, must ensure that any enclosing
850-
// extension is bound
851-
for (auto *context = containing_context; context;
852-
context = context->getParent()) {
853-
if (auto *d = context->getAsDecl()) {
854-
if (auto *ext = swift::dyn_cast<swift::ExtensionDecl>(d))
855-
ext->computeExtendedNominal();
856-
}
857-
}
858849
swift::Type type = containing_context->mapTypeIntoContext(
859850
var_decl->getInterfaceType());
860851
swift::TypedPattern *typed_pattern =

0 commit comments

Comments
 (0)