Merge pull request #262 from ranocha/hr/fix_multiplication

fix multiplication with multiple arguments and vectors

Author: isuruf

Project.toml

@@ -1,6 +1,6 @@
 name = "SymEngine"
 uuid = "123dc426-2d89-5057-bbad-38513e3affd8"
-version = "0.9.0"
+version = "0.9.1"
 
 [deps]
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"

src/mathops.jl

@@ -58,14 +58,14 @@ function prod(v::CVecBasic)
     return a
 end
 
-*(b1::Basic, b2::Basic, b3::Basic, bs...) = prod(convert(CVecBasic, [b1, b2, b3, bs...]))
-*(b1::Basic, b2::Basic, b3, bs...) = *(Basic(b1), Basic(b2), Basic(b3), bs...)
-*(b1, b2::Basic, b3::Basic, bs...) = *(Basic(b1), Basic(b2), Basic(b3), bs...)
-*(b1::Basic, b2, b3::Basic, bs...) = *(Basic(b1), Basic(b2), Basic(b3), bs...)
-
-*(b1::Basic, b2, b3, bs...) = *(Basic(b1), Basic(b2), Basic(b3), bs...)
-*(b1, b2::Basic, b3, bs...) = *(Basic(b1), Basic(b2), Basic(b3), bs...)
-*(b1, b2, b3::Basic, bs...) = *(Basic(b1), Basic(b2), Basic(b3), bs...)
+*(b1::Basic, b2::Basic, b3::Basic, bs::Vararg{Number, N}) where {N} = prod(convert(CVecBasic, [b1, b2, b3, bs...]))
+*(b1::Basic, b2::Basic, b3::Number, bs::Vararg{Number, N}) where {N} = *(Basic(b1), Basic(b2), Basic(b3), bs...)
+*(b1::Number, b2::Basic, b3::Basic, bs::Vararg{Number, N}) where {N} = *(Basic(b1), Basic(b2), Basic(b3), bs...)
+*(b1::Basic, b2::Number, b3::Basic, bs::Vararg{Number, N}) where {N} = *(Basic(b1), Basic(b2), Basic(b3), bs...)
+
+*(b1::Basic, b2::Number, b3::Number, bs::Vararg{Number, N}) where {N} = *(Basic(b1), Basic(b2), Basic(b3), bs...)
+*(b1::Number, b2::Basic, b3::Number, bs::Vararg{Number, N}) where {N} = *(Basic(b1), Basic(b2), Basic(b3), bs...)
+*(b1::Number, b2::Number, b3::Basic, bs::Vararg{Number, N}) where {N} = *(Basic(b1), Basic(b2), Basic(b3), bs...)
 
 
 ## ## constants

test/runtests.jl

@@ -42,6 +42,16 @@ c = prod(convert(SymEngine.CVecBasic, [x, x, 2]))
 @test 2 * x * 3 == 6 * x
 @test 3 * 2 * x == 6 * x
 
+# https://github.com/symengine/SymEngine.jl/issues/259
+@testset "Issue #259" begin
+    let (a, b, c) = symbols("a b c")
+        @test a * [b, c] == [a * b, a * c]
+        @test a * 1//3 * [b, c] == [a * b / 3, a * c / 3]
+        @test a * 1//3 * 3//4 * [b, c] == [a * b / 4, a * c / 4]
+        @test a * 1//3 * 3//4 * 4//5 * [b, c] == [a * b / 5, a * c / 5]
+    end
+end
+
 c = x ^ 5
 @test diff(c, x) == 5 * x ^ 4