Merge pull request #222 from robertfausk/fix_calling_static_method_when_in_object_context

dunglas · web-flow · commit acdb7f883fdf · 2019-08-23T21:09:21.000+02:00
Prevent call of self::getClient when not in static context
diff --git a/src/PantherTestCaseTrait.php b/src/PantherTestCaseTrait.php
@@ -158,7 +158,7 @@ protected static function createPantherClient(array $options = [], array $kernel
             static::bootKernel($kernelOptions);
         }
 
-        if (\is_callable([self::class, 'getClient'])) {
+        if (\is_callable([self::class, 'getClient']) && (new \ReflectionMethod(self::class, 'getClient'))->isStatic()) {
             return self::getClient(self::$pantherClient);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ protected static function createPantherClient(array $options = [], array $kernel`
`158`	`158`	`static::bootKernel($kernelOptions);`
`159`	`159`	`}`
`160`	`160`
`161`		`- if (\is_callable([self::class, 'getClient'])) {`
	`161`	`+ if (\is_callable([self::class, 'getClient']) && (new \ReflectionMethod(self::class, 'getClient'))->isStatic()) {`
`162`	`162`	`return self::getClient(self::$pantherClient);`
`163`	`163`	`}`
`164`	`164`