[Autocomplete] Does not work when Repository does not extend EntityRepository

[janopae]

When your Entities repository does not extend \Doctrine\ORM\EntityRepository, every request to the EntityAutocompleteController will result in a type error.

This is because the repository is accessed through a wrapper around the Doctrine registry (\Symfony\UX\Autocomplete\Doctrine\DoctrineRegistryWrapper), which instead of ObjectRepository typehints \Doctrine\ORM\EntityRepository.

The only case when methods of EntityRepository that are not in ObjectRepository are used, are however in

ux/src/Autocomplete/src/Form/WrappedEntityTypeAutocompleter.php

Line 56 in 67993da

$queryBuilder = $queryBuilder ?: $repository->createQueryBuilder('entity');

, only when a FormType does not declare a 'query_builder' – only then, $repository->createQueryBuilder('entity'); is being used. It should be possible to use Entity Repositories that don't extend the Doctrine implementation as long as you provide a 'query_builder'.

The normal EntityType allows using repositories that don't descent from Doctrine's default implementation.

[Kocal]

Hi,

Unfortunately we cannot make this change in 2.x, because we also type-hint the first argument $repository of EntityAutocompleterInterface::createFilteredQueryBuilder to EntityRepository and this would be a BC break.

I don't see any BC layer possible, or am I missing something? cc @smnandre @kbond)

However, that's do-able for 3.x

[smnandre]

I'm not sure in fact, or Doctrine itself should precise their documentation, as I only found EntityRepository in their documentation, and that's what EntityManager->getRepository() returns, no ?

[Kocal]

Our wrapper \Symfony\UX\Autocomplete\Doctrine\DoctrineRegistryWrapper::getRepository() is typed to EntityRepository, but internally it relies on \Doctrine\Persistence\AbstractManagerRegistry::getRepository() which is typed to ObjectRepository

[janopae]

Unfortunately we cannot make this change in 2.x, because we also type-hint the first argument $repository of EntityAutocompleterInterface::createFilteredQueryBuilder to EntityRepository and this would be a BC break.

It is possible for implementations of that Interface to accept an ObjectRepositoryInterface without requiring anything wider than EntityRepository in the Interface itself.

One could

1. change AbstractManagerRegistry::getRepository() to return ObjectRepositoryInterface and WrappedEntityTypeAutocompleter::createFilteredQueryBuilder to accept ObjectRepositoryInterface in 2.x
2. change EntityAutocompleterInterface::createFilteredQueryBuilder to accept ObjectRepositoryInterface in 3.x

This would look a bit awkward in 2.x, as it would look like AutocompleteResultsExecutor::fetchResults passed an instance of ObjectRepositoryInterface into a method that only accepts EntityRepository.

But the actual implementation used might accept more types – if not, a TypeError will be thrown. This would essentially be the same behaviour we have now: When DoctrineRegistryWrapper::getRepository() returns something else than EntityRepository, there will be a TypeError.

Except when the implementation of EntityAutocompleterInterface happens to accept ObjectRepositoryInterface, we would let that through if we widened the return type of AbstractManagerRegistry::getRepository().