Skip to content

Commit 89e6502

Browse files
authored
Remove a few rules that are covered in airbnb now (#37)
* Remove a few rules that are covered in airbnb now * Update config.yml
1 parent 9fe4922 commit 89e6502

File tree

5 files changed

+80
-42
lines changed

5 files changed

+80
-42
lines changed

.circleci/config.yml

Lines changed: 63 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,49 +3,80 @@ jobs:
33
build:
44
docker:
55
- image: circleci/node:8
6+
working_directory: ~/repo
67
steps:
78
- checkout
89
- run: npm install
910
- run: npm run lint
1011
- persist_to_workspace:
11-
root: ~/
12-
paths:
13-
- project
12+
root: ~/repo
13+
paths: .
1414
test-node8:
1515
docker:
1616
- image: circleci/node:8
17+
working_directory: ~/repo
1718
steps:
1819
- attach_workspace:
19-
at: ~/
20+
at: ~/repo
2021
- run: npm test
2122
test-node9:
2223
docker:
2324
- image: circleci/node:9
25+
working_directory: ~/repo
2426
steps:
2527
- attach_workspace:
26-
at: ~/
28+
at: ~/repo
2729
- run: npm test
2830
test-node10:
2931
docker:
3032
- image: circleci/node:10
33+
working_directory: ~/repo
3134
steps:
3235
- attach_workspace:
33-
at: ~/
36+
at: ~/repo
3437
- run: npm test
3538
test-node11:
3639
docker:
3740
- image: circleci/node:11
41+
working_directory: ~/repo
3842
steps:
3943
- attach_workspace:
40-
at: ~/
44+
at: ~/repo
4145
- run: npm test
4246
test-node12:
4347
docker:
4448
- image: circleci/node:12
49+
working_directory: ~/repo
4550
steps:
4651
- attach_workspace:
47-
at: ~/
52+
at: ~/repo
4853
- run: npm test
54+
publish-beta:
55+
docker:
56+
- image: circleci/node:10
57+
working_directory: ~/repo
58+
steps:
59+
- attach_workspace:
60+
at: ~/repo
61+
- run:
62+
name: Authenticate with registry
63+
command: echo "//registry.npmjs.org/:_authToken=$npm_TOKEN" >> ~/.npmrc
64+
- run:
65+
name: Publish to beta channel
66+
command: npm publish --tag beta
67+
publish-stable:
68+
docker:
69+
- image: circleci/node:10
70+
working_directory: ~/repo
71+
steps:
72+
- attach_workspace:
73+
at: ~/repo
74+
- run:
75+
name: Authenticate with registry
76+
command: echo "//registry.npmjs.org/:_authToken=$npm_TOKEN" >> ~/.npmrc
77+
- run:
78+
name: Publish to stable channel
79+
command: npm publish --tag latest
4980

5081
workflows:
5182
version: 2
@@ -67,3 +98,27 @@ workflows:
6798
- test-node12:
6899
requires:
69100
- build
101+
- publish-beta:
102+
requires:
103+
- test-node8
104+
- test-node9
105+
- test-node10
106+
- test-node11
107+
- test-node12
108+
filters:
109+
tags:
110+
only: /^v\d*\.\d*\.\d*-beta\.\d*$/
111+
branches:
112+
ignore: /.*/
113+
- publish-stable:
114+
requires:
115+
- test-node8
116+
- test-node9
117+
- test-node10
118+
- test-node11
119+
- test-node12
120+
filters:
121+
tags:
122+
only: /^v\d*\.\d*\.\d*$/
123+
branches:
124+
ignore: /.*/

.travis.yml

Lines changed: 0 additions & 29 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,14 @@ This project adheres to [Semantic Versioning](http://semver.org/).
1111

1212
### Removed
1313

14+
## [6.3.0] - 2019-04-27
15+
### Removed
16+
Removed the following rules that are now covered with the same config in Airbnb.
17+
* [class-methods-use-this](https://eslint.org/docs/rules/class-methods-use-this)
18+
* [default-case](https://eslint.org/docs/rules/default-case)
19+
* [eqeqeq](https://eslint.org/docs/rules/eqeqeq)
20+
* [default-case](https://eslint.org/docs/rules/default-case)
21+
1422
## [6.2.0] - 2019-04-26
1523
### Changed
1624
* Updated [no-warning-comments](https://eslint.org/docs/rules/no-warning-comments) from `error` to `warn`.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
[![license](https://img.shields.io/github/license/tclindner/eslint-config-tc.svg?maxAge=2592000&style=flat-square)](https://github.com/tclindner/eslint-config-tc/blob/master/LICENSE)
77
[![npm](https://img.shields.io/npm/v/eslint-config-tc.svg?maxAge=2592000?style=flat-square)](https://www.npmjs.com/package/eslint-config-tc)
8-
[![Travis](https://img.shields.io/travis/tclindner/eslint-config-tc.svg?maxAge=2592000?style=flat-square)](https://travis-ci.org/tclindner/eslint-config-tc)
8+
[![CircleCI](https://circleci.com/gh/tclindner/eslint-config-tc.svg?style=svg&circle-token=76cd4906598cc891780e51115a0c8269700a64ec)](https://circleci.com/gh/tclindner/eslint-config-tc)
99
[![Dependency Status](https://david-dm.org/tclindner/eslint-config-tc.svg?style=flat-square)](https://david-dm.org/tclindner/eslint-config-tc)
1010
[![devDependency Status](https://david-dm.org/tclindner/eslint-config-tc/dev-status.svg?style=flat-square)](https://david-dm.org/tclindner/eslint-config-tc#info=devDependencies)
1111

package.json

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "eslint-config-tc",
3-
"version": "6.2.0",
3+
"version": "6.3.0",
44
"description": "ESLint shareable config for JavaScript projects",
55
"keywords": [
66
"eslintconfig",
@@ -21,6 +21,10 @@
2121
"type": "git",
2222
"url": "git+https://github.com/tclindner/eslint-config-tc.git"
2323
},
24+
"files": [
25+
"rules",
26+
"CONTRIBUTING.md"
27+
],
2428
"main": "index.js",
2529
"scripts": {
2630
"eslint": "eslint . --format=node_modules/eslint-formatter-pretty",
@@ -31,17 +35,17 @@
3135
"devDependencies": {
3236
"eslint": "^5.16.0",
3337
"eslint-formatter-pretty": "^2.1.1",
34-
"eslint-plugin-import": "^2.17.1",
38+
"eslint-plugin-import": "^2.17.2",
3539
"eslint-plugin-prettier": "^3.0.1",
36-
"is-plain-obj": "^1.1.0",
40+
"is-plain-obj": "^2.0.0",
3741
"jest": "^24.7.1",
3842
"npm-package-json-lint": "^3.6.0",
3943
"npm-package-json-lint-config-tc": "^2.1.0",
4044
"prettier": "^1.17.0"
4145
},
4246
"dependencies": {
4347
"eslint-config-airbnb-base": "^13.1.0",
44-
"eslint-config-prettier": "^4.1.0"
48+
"eslint-config-prettier": "^4.2.0"
4549
},
4650
"peerDependencies": {
4751
"eslint": "^5.16.0",

0 commit comments

Comments
 (0)