Bug #139457 fix: Warning Install path does not exist. (#41)

shinderohanoffical · manojLondhe · commit fe3071ba5c6c · 2019-01-17T12:00:08.000+05:30
* Bug #139457 fix: Warning Install path does not exist. Package Update: There was an error installing an extension: com_tjnotification.zip × Error Error installing package

* Bug #139457 fix: Warning Install path does not exist. Package Update: There was an error installing an extension: com_tjnotification.zip × Error Error installing package
diff --git a/src/com_tjnotifications/install.tjnotifications.php b/src/com_tjnotifications/install.tjnotifications.php
@@ -31,7 +31,6 @@ class Com_TjnotificationsInstallerScript
 	/** @var array Obsolete files and folders to remove*/
 	private $removeFilesAndFolders = array(
 		'files' => array(
-			'administrator/components/com_tjnotifications/tjnotifications.xml'
 		),
 		'folders' => array(
 		)
@@ -395,12 +394,10 @@ private function removeObsoleteFilesAndFolders($removeFilesAndFolders)
 			{
 				$f = JPATH_ROOT . '/' . $file;
 
-				if (!JFile::exists($f))
+				if (JFile::exists($f))
 				{
-					continue;
+					JFile::delete($f);
 				}
-
-				JFile::delete($f);
 			}
 		}
 
@@ -411,12 +408,10 @@ private function removeObsoleteFilesAndFolders($removeFilesAndFolders)
 			{
 				$f = JPATH_ROOT . '/' . $folder;
 
-				if (!JFolder::exists($f))
+				if (JFolder::exists($f))
 				{
-					continue;
+					JFolder::delete($f);
 				}
-
-				JFolder::delete($f);
 			}
 		}
 	}
diff --git a/src/com_tjnotifications/site/language/en-GB.com_tjnotifications.ini b/src/com_tjnotifications/site/language/en-GB.com_tjnotifications.ini
diff --git a/src/com_tjnotifications/tjnotifications.xml b/src/com_tjnotifications/tjnotifications.xml
@@ -28,7 +28,7 @@
 		<folder>controllers</folder>
 	</files>
 	<languages folder="site/language">
-		<language tag="en-GB">en-GB.com_tjnotification.ini</language>
+		<language tag="en-GB">en-GB.com_tjnotifications.ini</language>
 	</languages>
 	<administration>
 		<menu>com_tjnotifications</menu>
@@ -49,5 +49,5 @@
 			<language tag="en-GB">en-GB.com_tjnotifications.sys.ini</language>
 		</languages>
 	</administration>
-	<scriptfile>install.tjnotification.php</scriptfile>
+	<scriptfile>install.tjnotifications.php</scriptfile>
 </extension>

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,6 @@ class Com_TjnotificationsInstallerScript`
`31`	`31`	`/** @var array Obsolete files and folders to remove*/`
`32`	`32`	`private $removeFilesAndFolders = array(`
`33`	`33`	`'files' => array(`
`34`		`- 'administrator/components/com_tjnotifications/tjnotifications.xml'`
`35`	`34`	`),`
`36`	`35`	`'folders' => array(`
`37`	`36`	`)`
`@@ -395,12 +394,10 @@ private function removeObsoleteFilesAndFolders($removeFilesAndFolders)`
`395`	`394`	`{`
`396`	`395`	`$f = JPATH_ROOT . '/' . $file;`
`397`	`396`
`398`		`- if (!JFile::exists($f))`
	`397`	`+ if (JFile::exists($f))`
`399`	`398`	`{`
`400`		`- continue;`
	`399`	`+ JFile::delete($f);`
`401`	`400`	`}`
`402`		`-`
`403`		`- JFile::delete($f);`
`404`	`401`	`}`
`405`	`402`	`}`
`406`	`403`
`@@ -411,12 +408,10 @@ private function removeObsoleteFilesAndFolders($removeFilesAndFolders)`
`411`	`408`	`{`
`412`	`409`	`$f = JPATH_ROOT . '/' . $folder;`
`413`	`410`
`414`		`- if (!JFolder::exists($f))`
	`411`	`+ if (JFolder::exists($f))`
`415`	`412`	`{`
`416`		`- continue;`
	`413`	`+ JFolder::delete($f);`
`417`	`414`	`}`
`418`		`-`
`419`		`- JFolder::delete($f);`
`420`	`415`	`}`
`421`	`416`	`}`
`422`	`417`	`}`