Fixes #38498 - Add Reboot power operation to Redfish provider

Bug #3073 is caused by 3 things:
1. Foreman core doesn't call BMC proxy's API correctly
   - Changing power state to 'Reboot' via Web GUI calls BMC proxy's 'soft'
     power action
   - Changing power state to 'Reset' via Web GUI calls BMC proxy's 'cycle'
     power action
2. Foreman BMC proxy doesn't support reboot at all BMC provider
3. Foreman BMC proxy doesn't support reset(powerreset) at Redfish provider

2nd & 3rd item are mentioned in #38498. And this PR fixes 2nd item.

For backward compatibility, poweraction_fix_3_17 capability is introduced
to smart proxy at PRs related to #38498. PR related to #3073 adds logic
to determine if smart proxy supports this capability into Foreman core.

Author: vanou

modules/bmc/base.rb

@@ -46,6 +46,10 @@ def powercycle
         raise NotImplementedError.new
       end
 
+      def powerreboot
+        raise NotImplementedError.new
+      end
+
       def bootdevice
         raise NotImplementedError.new
       end

modules/bmc/bmc_api.rb

@@ -163,7 +163,7 @@ class Api < ::Sinatra::Base
     put "/:host/chassis/power/?:action?" do
       # return hint on valid options
       if params[:action].nil?
-        return { :actions => ["on", "off", "cycle", "soft", "reset"] }.to_json
+        return { :actions => ["on", "off", "cycle", "soft", "reset", "reboot"] }.to_json
       end
       bmc_setup
       begin
@@ -178,6 +178,8 @@ class Api < ::Sinatra::Base
             { :action => params[:action], :result => @bmc.poweroff(true) }.to_json
           when "reset"
             { :action => params[:action], :result => @bmc.powerreset }.to_json
+          when "reboot"
+            { :action => params[:action], :result => @bmc.powerreboot }.to_json
           else
             { :error => "The action: #{params[:action]} is not a valid action" }.to_json
         end

modules/bmc/bmc_plugin.rb

@@ -11,6 +11,7 @@ class Plugin < Proxy::Plugin
     capability 'shell'
     capability 'ssh'
     capability -> { Proxy::BMC::IPMI.providers_installed }
+    capability 'poweraction_fix_3_17'
 
     # Load IPMI to ensure the capabilities can be determined
     load_classes do

modules/bmc/redfish.rb

@@ -74,6 +74,10 @@ def powercycle
         poweraction('PowerCycle')
       end
 
+      def powerreboot
+        poweraction('GracefulRestart')
+      end
+
       def poweron
         poweraction('On')
       end

test/bmc/bmc_api_test.rb

@@ -583,6 +583,13 @@ def test_api_calls_redfish_provider_cycle
     assert expect.once
   end
 
+  def test_api_calls_redfish_provider_reboot
+    expect = Proxy::BMC::Redfish.any_instance.stubs(:powerreboot)
+    test_args = { 'bmc_provider' => 'redfish' }
+    put "/#{@host}/chassis/power/reboot", test_args
+    assert expect.once
+  end
+
   def test_api_can_pass_options_in_body
     Rubyipmi.stubs(:is_provider_installed?).returns(true)
     args = { 'bmc_provider' => 'freeipmi', :options => {:driver => 'lan20', :privilege => 'USER'} }.to_json

test/bmc/bmc_redfish_test.rb

@@ -21,4 +21,11 @@ def test_redfish_provider_cycle
       to_return(status: 200, body: JSON.generate({}))
     assert @bmc.powercycle
   end
+
+  def test_redfish_provider_reboot
+    stub_request(:post, "#{@protocol}://#{@host}#{SYSTEM_DATA['Actions']['#ComputerSystem.Reset']['target']}").
+      with(body: JSON.generate({ "ResetType" => "GracefulRestart" })).
+      to_return(status: 200, body: JSON.generate({}))
+    assert @bmc.powerreboot
+  end
 end

test/bmc/bmc_test.rb

@@ -56,6 +56,12 @@ def test_should_power_reset
     assert bmc.powerreset
   end
 
+  def test_should_power_reboot
+    assert_raise(NotImplementedError) do
+      bmc.powerreboot
+    end
+  end
+
   def test_should_bootpxe
     Rubyipmi::Ipmitool::Chassis.any_instance.expects(:bootpxe).returns(true)
     bmc.bootpxe

test/bmc/integration_test.rb

@@ -16,7 +16,7 @@ def test_features
     mod = response['bmc']
     refute_nil(mod)
     assert_equal('running', mod['state'], Proxy::LogBuffer::Buffer.instance.info[:failed_modules][:bmc])
-    assert_equal(['redfish', 'shell', 'ssh'], mod['capabilities'])
+    assert_equal(['poweraction_fix_3_17', 'redfish', 'shell', 'ssh'], mod['capabilities'])
 
     assert_equal({}, mod['settings'])
   end
@@ -32,7 +32,7 @@ def test_features_with_freeipmi_installed
     mod = response['bmc']
     refute_nil(mod)
     assert_equal('running', mod['state'], Proxy::LogBuffer::Buffer.instance.info[:failed_modules][:bmc])
-    assert_equal(['freeipmi', 'redfish', 'shell', 'ssh'], mod['capabilities'])
+    assert_equal(['freeipmi', 'poweraction_fix_3_17', 'redfish', 'shell', 'ssh'], mod['capabilities'])
 
     assert_equal({}, mod['settings'])
   end