Use more ruby naming convention duplicate_token_error?

Author: Ricard Forniol

lib/mongoid/token/collisions.rb

@@ -7,7 +7,7 @@ def resolve_token_collisions
           yield
         rescue Mongo::Error::OperationFailure => e
           resolver = self.class.resolvers.select do |r|
-            is_duplicate_token_error?(e, self, r.field_name)
+            duplicate_token_error?(e, self, r.field_name)
           end.first
           raise e unless resolver
           retries ||= resolver.retry_count
@@ -25,7 +25,7 @@ def raise_collision_retries_exceeded_error(field_name, retry_count)
         raise Mongoid::Token::CollisionRetriesExceeded.new(self, retry_count)
       end
 
-      def is_duplicate_token_error?(err, document, field_name)
+      def duplicate_token_error?(err, document, field_name)
         err.message =~ /(11000|11001)/ &&
           err.message =~ /dup key/ &&
           err.message =~ /"#{document.send(field_name)}"/ &&

spec/mongoid/token/collisions_spec.rb

@@ -10,7 +10,7 @@
         allow(resolver).to receive(:field_name).and_return(:token)
         allow(resolver).to receive(:create_new_token_for){|doc|}
         document.class.send(:include, Mongoid::Token::Collisions)
-        allow(document).to receive(:is_duplicate_token_error?).and_return(true)
+        allow(document).to receive(:duplicate_token_error?).and_return(true)
         allow(document.class).to receive(:resolvers).and_return([resolver])
       end
 
@@ -58,7 +58,7 @@
 
       context "and a different index is violated" do
         it "should bubble the operation failure" do
-          allow(document).to(receive(:is_duplicate_token_error?)
+          allow(document).to(receive(:duplicate_token_error?)
                              .and_return(false))
           allow(resolver).to receive(:retry_count).and_return(3)
           e = Mongo::Error::OperationFailure.new("nope")
@@ -98,7 +98,7 @@
     end
   end
 
-  describe "#is_duplicate_token_error?" do
+  describe "#duplicate_token_error?" do
     before(:each) do
       document.class.send(:include, Mongoid::Token::Collisions)
     end
@@ -113,7 +113,7 @@
                                   '{ : "tokenvalue123" } (11000) (on localhost'\
                                   ':27017, legacy retry, attempt 1) (on localh'\
                                   'ost:27017, legacy retry, attempt 1)'))
-        expect(document.is_duplicate_token_error?(err, document, :token)).to(
+        expect(document.duplicate_token_error?(err, document, :token)).to(
           be(true)
         )
       end