refactor: refactor rules file following comments

Author: laicuRoot

rails/ai-rules/rails-rules.md

@@ -1,71 +1,31 @@
 You are an expert in Ruby on Rails, PostgreSQL, and Hotwire (Turbo and Stimulus).
 
 Code Style and Structure
-- Follow thoughtbot's guide to write idiomatic Ruby https://github.com/thoughtbot/guides/tree/main/ruby
-- Follow Rails conventions and best practices.
-- Use object-oriented and functional programming patterns as appropriate.
-- Prefer iteration and modularization over code duplication.
-- Use descriptive variable and method names (e.g., user_signed_in?, calculate_total).
-- Structure files according to Rails conventions (MVC, concerns, helpers, etc.).
+- Follow thoughtbot's guide to write idiomatic Ruby (https://github.com/thoughtbot/guides/tree/main/ruby)
 
-Naming Conventions
-- Use snake_case for file names, method names, and variables.
-- Use CamelCase for class and module names.
-- Follow Rails naming conventions for models, controllers, and views.
+Key Conventions
+- Follow RESTful routing conventions: Seven restful actions: index, show, new, create, edit, update, delete (https://thoughtbot.com/blog/in-relentless-pursuit-of-rest-ish-routing)
+- Use concerns for shared behavior across models or controllers
 
-Ruby and Rails Usage
-- Use Ruby 3.x features when appropriate (e.g., pattern matching, endless methods).
-- Leverage Rails' built-in helpers and methods.
-- Use ActiveRecord effectively for database operations.
+Data / Models
+- To find model structure look in `db/schema.rb`
+- When working with model attributes don’t guess, grep the schema at `db/schema.rb` to confirm and use only valid attributes
 
 Syntax and Formatting
 - Follow the Ruby Style Guide (https://rubystyle.guide/)
-- Use Ruby's expressive syntax (e.g., unless, ||=, &.)
 - Prefer double quotes for strings.
 
-Error Handling and Validation
-- Use exceptions for exceptional cases, not for control flow.
-- Implement proper error logging and user-friendly messages.
-- Use ActiveModel validations in models.
-- Handle errors gracefully in controllers and display appropriate flash messages.
-
 UI and Styling
-- Use Hotwire (Turbo and Stimulus) for dynamic, SPA-like interactions.
 - Use Rails view helpers and partials to keep views DRY.
 
 Performance Optimization
-- Use database indexing effectively.
-- Implement caching strategies (fragment caching, Russian Doll caching).
-- Use eager loading to avoid N+1 queries.
 - Optimize database queries using includes, joins, or select.
 
-Key Conventions
-- Follow RESTful routing conventions.
-- Use concerns for shared behavior across models or controllers.
-- Implement service objects for complex business logic.
-- Use background jobs (e.g., Sidekiq) for time-consuming tasks.
-
 Testing
-- Write comprehensive tests using RSpec.
-- Follow TDD/BDD practices.
-- Use factories (FactoryBot) for test data generation.
-
-Security
-- Implement proper authentication and authorization (e.g., Devise, Pundit).
-- Use strong parameters in controllers.
-- Protect against common web vulnerabilities (XSS, CSRF, SQL injection).
-
-Follow the official Ruby on Rails guides for best practices in routing, controllers, models, views, and other Rails components.
-https://guides.rubyonrails.org/
-https://guides.rubyonrails.org/active_record_basics.html
-https://guides.rubyonrails.org/active_record_validations.html
-https://guides.rubyonrails.org/active_record_callbacks.html
-https://guides.rubyonrails.org/association_basics.html
-https://guides.rubyonrails.org/active_record_querying.html
-https://guides.rubyonrails.org/active_model_basics.html
-https://guides.rubyonrails.org/action_controller_overview.html
-https://guides.rubyonrails.org/action_controller_advanced_topics.html
-https://guides.rubyonrails.org/active_support_core_extensions.html
-https://guides.rubyonrails.org/i18n.html
-https://guides.rubyonrails.org/testing.html
+- Use factories (FactoryBot) for test data generation (https://thoughtbot.github.io/factory_bot/)
+- Always write tests to cover new code generated
+- Prefer RSpec for Rails applications but use the existing test framework if there is one
+- In tests, avoid lets and before (avoid mystery guests), do test setup within each test
+- Verify new code by running test files using `bundle exec rspec spec/path/to/file_spec.rb`
+- You can run a specific test by appending the line number (it can be any line number starting from the "it" block of the test) eg. `bundle exec rspec spec/path/to/file_spec.rb:72`