-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improve the accessibility guide #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fixed broken links - mention some good browser extensions for testing - mention Capybara accessibility tools - suggest using role selectors in testing - suggest validating HTML and announcing content changes
Add WCAG references and supporting evidence to recommendations. Some developers are unfamiliar with accessibility terminology ("focus traps", etc) or how disabled users are affected. These link help give more context and often give concrete examples of how and why to implement a recommendation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the accessibility guide by adding important resources, fixing broken links, and providing more comprehensive guidance with WCAG references. The changes aim to make the guide more actionable and educational for developers working on accessibility implementations.
Key changes:
- Added new browser extensions and testing tools for accessibility auditing
- Integrated WCAG 2.2 guideline references throughout the document
- Included guidance on role selectors for testing and HTML validation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
FerPerales
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There are a couple of suggested correction that makes sense to apply
Fixed a broken link and removed an unused link
Removed unused link
There are a few goals here: