Skip to content

Conversation

@pangolingo
Copy link
Contributor

@pangolingo pangolingo commented Sep 12, 2025

  • fixed broken links
  • mention some good browser extensions for testing
  • mention Capybara accessibility tools
  • suggest using role selectors in testing
  • suggest validating HTML and announcing content changes
  • link to WCAG guidelines and supporting documentation

There are a few goals here:

  • Add some missing guidelines
  • Link to more tools - especially thoughtbot-supported tools like CapybaraAccessibilityAudit
  • Give context to the recommendations. Some developers are unfamiliar with accessibility terminology ("focus traps", etc) or how disabled users are affected. These link help give more context and often give concrete examples of how and why to implement a recommendation.

- fixed broken links
- mention some good browser extensions for testing
- mention Capybara accessibility tools
- suggest using role selectors in testing
- suggest validating HTML and announcing content changes
Add WCAG references and supporting evidence to recommendations. Some developers are unfamiliar with accessibility terminology ("focus traps", etc) or how disabled users are affected. These link help give more context and often give concrete examples of how and why to implement a recommendation.
@pangolingo pangolingo marked this pull request as ready for review September 12, 2025 22:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the accessibility guide by adding important resources, fixing broken links, and providing more comprehensive guidance with WCAG references. The changes aim to make the guide more actionable and educational for developers working on accessibility implementations.

Key changes:

  • Added new browser extensions and testing tools for accessibility auditing
  • Integrated WCAG 2.2 guideline references throughout the document
  • Included guidance on role selectors for testing and HTML validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@FerPerales FerPerales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are a couple of suggested correction that makes sense to apply

Fixed a broken link and removed an unused link
Removed unused link
@pangolingo pangolingo merged commit 5d7745c into main Oct 3, 2025
2 checks passed
@pangolingo pangolingo deleted the di/accessibility-guide-improvements branch October 3, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants