-
Notifications
You must be signed in to change notification settings - Fork 502
fix(pull): enhance pull function type definition #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ssi02014
wants to merge
8
commits into
toss:main
Choose a base branch
from
ssi02014:fix/pull
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 468 468
Lines 4439 4439
Branches 1309 1309
=======================================
Hits 4428 4428
Misses 11 11 🚀 New features to boost your workflow:
|
ssi02014
commented
Jul 1, 2025
|
|
||
| bench('es-toolkit/pull', () => { | ||
| pullToolkit([...array], even); | ||
| pullToolkit([...array], ...even); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a type error, which I fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion, given the use case of the
pullfunction, the type ofvaluesToRemovecould be defined with a clearer type thanunknown.For example, it is unlikely that you will ever want to remove an element that is completely separate from the
arrarray element type, as shown below.Since
unknownis a broad type, why not improve the developer experience by improving the type ofvaluesToRemove?It would be nice to catch type errors in advance.
I was thinking that for
compat/pull, it would be better to match the type of lodash for compatibility withlodash.However,
valuesin thecompat/pullfunction can also set the type more narrowly.The test code and existing logic is largely unchanged.
If you have additional ideas and feedback, we'd love to hear them.