Skip to content

Conversation

@D-Sketon
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings October 24, 2025 17:34
@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
es-toolkit Ready Ready Preview Comment Oct 24, 2025 5:44pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes TypeScript errors in benchmark files by adding explicit type annotations to function parameters, correcting function calls, removing invalid test cases, and modernizing constructor functions to ES6 classes.

Key changes:

  • Added type annotations to arrow function parameters throughout benchmark files
  • Corrected API usage (e.g., pull function calls, spread parameters)
  • Removed invalid test cases with non-existent types and string number arguments

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
xorBy.bench.ts Added type annotations to idMapper function parameters
wrap.bench.ts Added any type annotation to function parameter
uniqWith.bench.ts Added type annotations to comparator function parameters
unionWith.bench.ts Added type annotations to equality comparator parameters
unionBy.bench.ts Added type annotations to getId function parameter
truncate.bench.ts Removed unused import and benchmarks for non-compat truncate function
transform.bench.ts Added number type annotation to value parameter
toPlainObject.bench.ts Modernized constructor function to ES6 class with typed prototype assignment
spread.bench.ts Removed incorrect second argument from spreadToolkit call
round.bench.ts Removed invalid string arguments from benchmark calls
pullAllWith.bench.ts Added type annotations to comparator function parameters
pull.bench.ts Fixed spread operator usage in function calls
overArgs.bench.ts Added as any[] type assertion for property shorthand arrays
mergeWith.bench.ts Changed parameter types from any to unknown
isMatchWith.bench.ts Added unknown type annotations to customizer parameters
isEqualWith.bench.ts Added unknown type annotations and null checks to customizers
invokeMap.bench.ts Added type annotations including this context type
intersectionWith.bench.ts Added type annotations to equality comparator parameters
includes.bench.ts Removed invalid Symbol test cases
hasIn.bench.ts Modernized constructor functions to ES6 classes
functionsIn.bench.ts Modernized constructor function to ES6 class
flattenDeep.bench.ts Added return type annotation to createNestedArray
flatten.bench.ts Added return type annotation and ts-expect-error comment
curryRight.bench.ts Fixed argument order in curried function calls
conformsTo.bench.ts Fixed import/variable naming and added missing type annotation
cond.bench.ts Added type annotations to predicate functions
cloneDeep.bench.ts Fixed property initialization syntax in class instance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (2687388) to head (66655e2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1502   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         468      468           
  Lines        4453     4453           
  Branches     1311     1311           
=======================================
  Hits         4448     4448           
  Misses          5        5           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@raon0211 raon0211 merged commit c1025a2 into toss:main Oct 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants