fix: normalize manifest dir

Signed-off-by: Ruben Romero Montes <[email protected]>

Author: ruromero

src/providers/base_java.js

@@ -175,22 +175,33 @@ export default class Base_Java {
 	 * @returns {string|undefined}
 	 */
 	traverseForWrapper(startingManifest, repoRoot = undefined) {
-		repoRoot = repoRoot || getGitRootDir(path.resolve(path.dirname(startingManifest))) || path.parse(path.resolve(startingManifest)).root
-
-		const wrapperName = this.localWrapper;
-		const wrapperPath = path.join(path.resolve(path.dirname(startingManifest)), wrapperName);
+		const normalizedManifest = this.normalizePath(startingManifest);
+		const currentDir = this.normalizePath(path.dirname(normalizedManifest));
+		repoRoot = repoRoot || getGitRootDir(currentDir) || path.parse(normalizedManifest).root;
+		const wrapperPath = path.join(currentDir, this.localWrapper);
 
 		try {
-			fs.accessSync(wrapperPath, fs.constants.X_OK)
-		} catch(error) {
+			fs.accessSync(wrapperPath, fs.constants.X_OK);
+			return wrapperPath;
+		}
+		catch (error) {
 			if (error.code === 'ENOENT') {
-				if (path.resolve(path.dirname(startingManifest)) === repoRoot) {
-					return undefined
+				const rootDir = path.parse(currentDir).root;
+				if (currentDir === repoRoot || currentDir === rootDir) {
+					return undefined;
+				}
+				const parentDir = path.dirname(currentDir);
+				if (parentDir === currentDir || parentDir === rootDir) {
+					return undefined;
 				}
-				return this.traverseForWrapper(path.resolve(path.dirname(startingManifest)), repoRoot)
+				return this.traverseForWrapper(path.join(parentDir, path.basename(normalizedManifest)), repoRoot);
 			}
-			throw new Error(`failure searching for ${this.localWrapper}`, {cause: error})
+			throw new Error(`failure searching for ${this.localWrapper}`, { cause: error });
 		}
-		return wrapperPath
+	}
+
+	normalizePath(thePath) {
+		const normalized = path.resolve(thePath).normalize();
+		return process.platform === 'win32' ? normalized.toLowerCase() : normalized;
 	}
 }

src/providers/java_gradle.js

@@ -200,8 +200,11 @@ export default class Java_gradle extends Base_java {
 	#getProperties(manifestPath, opts) {
 		let gradle = this.selectToolBinary(manifestPath, opts)
 		try {
-			let properties = this._invokeCommand(gradle, ['properties'], {cwd: path.dirname(manifestPath)})
-			return properties.toString()
+			const manifestDir = path.normalize(path.dirname(manifestPath));
+			const commandResult = this._invokeCommand(gradle, ['properties'], {
+				cwd: manifestDir
+			})
+			return commandResult.toString()
 		} catch (error) {
 			throw new Error(`Couldn't get properties of ${this._getManifestName()} file , Error message returned from gradle binary => ${EOL} ${error.message}`)
 		}
@@ -243,7 +246,10 @@ export default class Java_gradle extends Base_java {
 	#getDependencies(manifest, opts={}) {
 		const gradle = this.selectToolBinary(manifest, opts)
 		try {
-			const commandResult = this._invokeCommand(gradle, ['dependencies'], {cwd: path.dirname(manifest)})
+			const manifestDir = path.normalize(path.dirname(manifest));
+			const commandResult = this._invokeCommand(gradle, ['dependencies'], {
+				cwd: manifestDir
+			})
 			return commandResult.toString()
 		} catch (error) {
 			throw new Error(`Couldn't run gradle dependencies command, error message returned from gradle binary => ${EOL} ${error.message}`)