diff --git a/scripts/download.py b/scripts/download.py index accc208..6a05335 100644 --- a/scripts/download.py +++ b/scripts/download.py @@ -45,7 +45,26 @@ def untargz(filepath): print("Extracting: " + filepath) dirpath = os.path.dirname(filepath) with tarfile.open(filepath, "r:gz") as tf: - tf.extractall(dirpath) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, dirpath) os.remove(filepath)