Remove derived state check

Author: benjeffery

CHANGELOG.md

@@ -6,6 +6,9 @@
 
 - Drop Python 3.9 support, require Python >= 3.10 ({pr}`1044`, {user}`benjeffery`)
 
+- Remove overzealous derived state validation in C API. ({user}`benjeffery`)
+
+
 ## [0.4.1] - 2024-04-19
 
 ** Changes **

lib/err.c

@@ -88,9 +88,6 @@ tsi_strerror(int err)
         case TSI_ERR_BAD_MUTATION_SITE:
             ret = "Bad mutation information: site";
             break;
-        case TSI_ERR_BAD_MUTATION_DERIVED_STATE:
-            ret = "Bad mutation information: derived state";
-            break;
         case TSI_ERR_BAD_MUTATION_DUPLICATE_NODE:
             ret = "Bad mutation information: mutation already exists for this node.";
             break;

lib/err.h

@@ -18,7 +18,7 @@
 #define TSI_ERR_BAD_NUM_ALLELES                                     -14
 #define TSI_ERR_BAD_MUTATION_NODE                                   -15
 #define TSI_ERR_BAD_MUTATION_SITE                                   -16
-#define TSI_ERR_BAD_MUTATION_DERIVED_STATE                          -17
+// -17 used to be TSI_ERR_BAD_MUTATION_DERIVED_STATE
 #define TSI_ERR_BAD_MUTATION_DUPLICATE_NODE                         -18
 #define TSI_ERR_BAD_NUM_SAMPLES                                     -19
 #define TSI_ERR_TOO_MANY_SITES                                      -20

lib/tree_sequence_builder.c

@@ -423,10 +423,6 @@ tree_sequence_builder_add_mutation(
         ret = TSI_ERR_BAD_MUTATION_SITE;
         goto out;
     }
-    if (derived_state < 0 || derived_state >= (allele_t) self->sites.num_alleles[site]) {
-        ret = TSI_ERR_BAD_MUTATION_DERIVED_STATE;
-        goto out;
-    }
     /* Make sure there are no other mutations on this node */
     for (list_node = self->sites.mutations[site]; list_node != NULL;
          list_node = list_node->next) {