Skip to content

Commit d053aa6

Browse files
committed
stash
1 parent 85a2673 commit d053aa6

File tree

12 files changed

+587
-603
lines changed

12 files changed

+587
-603
lines changed

.eslintrc.js renamed to .eslintrc.cjs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,8 @@ module.exports = {
55
sourceType: 'module',
66
},
77
rules: {
8-
// I disagree
9-
'react/jsx-filename-extension': 'off',
108
// I disagree
119
'react/require-default-props': 'off',
12-
// Our babel config doesn't support class properties
13-
'react/state-in-constructor': 'off',
1410
// I disagree
1511
'react/function-component-definition': ['error', {
1612
namedComponents: 'function-declaration',
@@ -25,4 +21,13 @@ module.exports = {
2521
allowChildren: false,
2622
}],
2723
},
24+
overrides: [
25+
{
26+
files: ['**/*.ts', '**/*.tsx'],
27+
extends: ['airbnb-typescript'],
28+
parserOptions: {
29+
project: './tsconfig.json',
30+
},
31+
},
32+
],
2833
};

example/app.js renamed to example/app.tsx

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,14 @@ const videos = [
99
{ id: 169408731, name: 'Hoody - Like You' },
1010
];
1111

12-
class App extends React.Component {
13-
constructor(props) {
12+
interface State {
13+
videoIndex: number,
14+
volume: number,
15+
paused: boolean,
16+
}
17+
18+
class App extends React.Component<{}, State> {
19+
constructor(props: {}) {
1420
super(props);
1521

1622
this.state = {
@@ -25,7 +31,7 @@ class App extends React.Component {
2531
this.handleVolume = this.handleVolume.bind(this);
2632
}
2733

28-
handlePause(event) {
34+
handlePause(event: React.ChangeEvent<HTMLInputElement>) {
2935
this.setState({
3036
paused: event.target.checked,
3137
});
@@ -39,13 +45,13 @@ class App extends React.Component {
3945
this.setState({ paused: false });
4046
}
4147

42-
handleVolume(event) {
48+
handleVolume(event: React.ChangeEvent<HTMLInputElement>) {
4349
this.setState({
4450
volume: parseFloat(event.target.value),
4551
});
4652
}
4753

48-
selectVideo(index) {
54+
selectVideo(index: number) {
4955
this.setState({ videoIndex: index });
5056
}
5157

@@ -113,5 +119,5 @@ class App extends React.Component {
113119
}
114120
}
115121

116-
const root = ReactDOM.createRoot(document.querySelector('#example'));
122+
const root = ReactDOM.createRoot(document.querySelector('#example')!);
117123
root.render(<App />);

index.d.ts

Lines changed: 0 additions & 275 deletions
This file was deleted.

index.test-d.tsx

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
 (0)