Readding hole.cert.pl phishing list as one of the built-in lists in uBlock Origin

[nazywam]

Hey👋🏼 , I'm one of the maintainers of hole.cert.pl phishing list - https://cert.pl/en/warning-list/.

It's a list of phishing/scam domains targeting Polish Internet users. We have a pretty strict blocking process and very few false positives.

It was extremely helpful to be included as one of the default filter lists in Poland. It seems that it had been removed in gorhill/uBlock@e713e133eb due to our export size (we are blocking more phishing domains lately).

I'd love to to add a smaller export that would make it possible for the list to be resubmitted.

I've prepared a small analysis of of possible retention periods and their respective export sizes of the last year or so (https://hole.cert.pl/domains/v2/domains_adblock.txt is limited to last 6 months):

Would 1 month work or should we look at something even shorter?

P.S. This seemed like the most suitable place to post the question, let me know if there's a better one.

[nazywam]

The list was originally added in gorhill/uBlock@3d2f70a and there should be some discussion about it in https://github.com/uBlockOrigin/uBlock-discussions/discussions/890#discussioncomment-9632360 but I don't have access to that.

[krystian3w]

I suspect you don't have write permissions at gorhill/uBlock to create first PR, so you'll have to paste a link to your uBo project fork/commit with recovered json row with new URL.

[nazywam]

You're correct.
@gorhill @stephenhawk8054 The new export is available at https://hole.cert.pl/domains/v2/domains_ublock.txt

Support URLs (I'm not sure which version you'd rather have in there):

• pl - https://cert.pl/lista-ostrzezen/
• en - https://cert.pl/en/warning-list/

[u-RraaLL]

@nazywam wouldn't it make sense to remove www. from entries that have it? Since if they add a subdomain it won't catch?

[gorhill]

gorhill/uBlock@87dddb7

[stephenhawk8054]

@gorhill I forgot about Safari, would the list make compiling slower?

[gorhill]

I did not include it in uBOL.

[stephenhawk8054]

Hmm... I thought it's fine for uBOL chromium at least?

[gorhill]

Problem with including the list conditionally is that it's a sublist, and in Safari this would cause a single sublist in a parent list. Also, for now I prefer to be extremely careful about adding extra lists in uBOL, especially extra region-specific lists. We have something like 35 region lists, and if we do this for every region, we get too close to the built in MV3 limit for my comfort. (I actually do not know if all platforms followed Chromium in raising the limit to 100, used to be 50).

[u-RraaLL]

By the way, after the removal the original list moved to custom for people that had it enabled, so if the new list is added, will Polish users now have two lists enabled until they manually remove the old one?

Or will assets still be able to replace the list with the new one even though it was previously removed?

[krystian3w]

I think that this group of users will have it duplicated (they may have see an alternation of 0/x filters used between), someone would have to see if there is a loose relationship to POL-3 in the user data, which I doubt, the new URI (file or directory name) probably will not allow the entry to be moved to the regional sections, without rebuilding asset.json (a section used only to compare whether someone wants to subscribe to something other than Content and CDN) and requiring the manual addition of a fake parameter similar to the badlist.txt project (when someone has the misfortune of opening an active scam for over 3 months (helpless hosting provider and/or domain seller)).

---

I performed a forced update of assets.json and as a result the deactivated list with the old URL did not disappear, probably enabling it before updating assets.json does not change much.