add tests for project clean, resource clean

Author: simonLeary42

coldfront/core/project/tests/tests.py

@@ -3,6 +3,7 @@
 # SPDX-License-Identifier: AGPL-3.0-or-later
 
 import logging
+import sys
 from unittest.mock import patch
 
 from django.core.exceptions import ValidationError
@@ -379,3 +380,52 @@ def test_determine_automated_institution_choice_does_not_save_to_database(self):
         self.assertEqual(original_db_project.institution, "Default")
 
         self.assertNotEqual(project.institution, current_db_project.institution)
+
+
+class ProjectAttributeModelCleanMethodTests(TestCase):
+    def _test_clean(
+        self, project_attribute_type_name: str, project_attribute_values: list, expect_validation_error: bool
+    ):
+        attribute_type = PAttributeTypeFactory(name=project_attribute_type_name)
+        project_attribute_type = ProjectAttributeTypeFactory(attribute_type=attribute_type)
+        project_attribute = ProjectAttributeFactory(project_attribute_type=project_attribute_type)
+        for value in project_attribute_values:
+            with self.subTest(value=value):
+                if not isinstance(value, str):
+                    raise TypeError("project attribute value must be a string")
+                project_attribute.value = value
+                if expect_validation_error:
+                    with self.assertRaises(ValidationError):
+                        project_attribute.clean()
+                else:
+                    project_attribute.clean()
+
+    def test_expect_int_given_int(self):
+        self._test_clean("Int", ["-1", "0", "1", str(sys.maxsize)], False)
+
+    def test_expect_int_given_float(self):
+        self._test_clean("Int", ["-1.0", "0.0", "1.0", "2e30"], True)
+
+    def test_expect_int_given_garbage(self):
+        self._test_clean("Int", ["foobar", "", " ", "\0", "1j"], True)
+
+    def test_expect_float_given_int(self):
+        self._test_clean("Float", ["-1", "0", "1", str(sys.maxsize)], False)
+
+    def test_expect_float_given_float(self):
+        self._test_clean("Float", ["-1.0", "0.0", "1.0", "2e30"], False)
+
+    def test_expect_float_given_garbage(self):
+        self._test_clean("Float", ["foobar", "", " ", "\0", "1j"], True)
+
+    def test_expect_yes_no_given_yes_no(self):
+        self._test_clean("Yes/No", ["Yes", "No"], False)
+
+    def test_expect_yes_no_given_garbage(self):
+        self._test_clean("Yes/No", ["foobar", "", " ", "\0", "1", "1.0", "2e30", "1j", "yes", "no", "YES", "NO"], True)
+
+    def test_expect_date_given_date(self):
+        self._test_clean("Date", ["1970-01-01"], False)
+
+    def test_expect_date_given_garbage(self):
+        self._test_clean("Date", ["foobar", "", " ", "\0", "1", "1.0", "2e30", "1j"], True)

coldfront/core/resource/tests/tests.py

@@ -3,3 +3,71 @@
 # SPDX-License-Identifier: AGPL-3.0-or-later
 
 # Create your tests here.
+
+import logging
+import sys
+
+from django.core.exceptions import ValidationError
+from django.test import TestCase
+
+from coldfront.core.test_helpers.factories import (
+    RAttributeTypeFactory,
+    ResourceAttributeFactory,
+    ResourceAttributeTypeFactory,
+)
+
+logging.disable(logging.CRITICAL)
+
+
+class ResourceAttributeModelCleanMethodTests(TestCase):
+    def _test_clean(
+        self, resource_attribute_type_name: str, resource_attribute_values: list, expect_validation_error: bool
+    ):
+        attribute_type = RAttributeTypeFactory(name=resource_attribute_type_name)
+        resource_attribute_type = ResourceAttributeTypeFactory(attribute_type=attribute_type)
+        resource_attribute = ResourceAttributeFactory(resource_attribute_type=resource_attribute_type)
+        for value in resource_attribute_values:
+            with self.subTest(value=value):
+                if not isinstance(value, str):
+                    raise TypeError("resource attribute value must be a string")
+                resource_attribute.value = value
+                if expect_validation_error:
+                    with self.assertRaises(ValidationError):
+                        resource_attribute.clean()
+                else:
+                    resource_attribute.clean()
+
+    def test_expect_int_given_int(self):
+        self._test_clean("Int", ["-1", "0", "1", str(sys.maxsize)], False)
+
+    def test_expect_int_given_float(self):
+        self._test_clean("Int", ["-1.0", "0.0", "1.0", "2e30"], True)
+
+    def test_expect_int_given_garbage(self):
+        self._test_clean("Int", ["foobar", "", " ", "\0", "1j"], True)
+
+    def test_expect_public_private_given_public_private(self):
+        self._test_clean("Public/Private", ["Public", "Private"], False)
+
+    def test_expect_public_private_given_garbage(self):
+        self._test_clean(
+            "Public/Private",
+            ["foobar", "", " ", "\0", "1", "1.0", "2e30", "1j", "public", "private", "PUBLIC", "PRIVATE"],
+            True,
+        )
+
+    def test_expect_active_inactive_given_active_inactive(self):
+        self._test_clean("Active/Inactive", ["Active", "Inactive"], False)
+
+    def test_expect_active_inactive_given_garbage(self):
+        self._test_clean(
+            "Active/Inactive",
+            ["foobar", "", " ", "\0", "1", "1.0", "2e30", "1j", "active", "inactive", "ACTIVE", "INACTIVE"],
+            True,
+        )
+
+    def test_expect_date_given_date(self):
+        self._test_clean("Date", ["1970-01-01"], False)
+
+    def test_expect_date_given_garbage(self):
+        self._test_clean("Date", ["foobar", "", " ", "\0", "1", "1.0", "2e30", "1j"], True)

coldfront/core/test_helpers/factories.py

@@ -41,7 +41,10 @@
     ProjectUserStatusChoice,
 )
 from coldfront.core.publication.models import PublicationSource
-from coldfront.core.resource.models import Resource, ResourceType
+from coldfront.core.resource.models import (
+    AttributeType as RAttributeType,
+)
+from coldfront.core.resource.models import Resource, ResourceAttribute, ResourceAttributeType, ResourceType
 from coldfront.core.user.models import UserProfile
 
 ### Default values and Faker provider setup ###
@@ -240,6 +243,35 @@ class Meta:
     resource_type = SubFactory(ResourceTypeFactory)
 
 
+### Resource Attribute factories ###
+
+
+class RAttributeTypeFactory(DjangoModelFactory):
+    class Meta:
+        model = RAttributeType
+        django_get_or_create = ("name",)
+
+    name = factory.Faker("attr_type")
+
+
+class ResourceAttributeTypeFactory(DjangoModelFactory):
+    class Meta:
+        model = ResourceAttributeType
+        django_get_or_create = ("name",)
+
+    name = "Test attribute type"
+    attribute_type = SubFactory(RAttributeTypeFactory)
+
+
+class ResourceAttributeFactory(DjangoModelFactory):
+    class Meta:
+        model = ResourceAttribute
+
+    resource_attribute_type = SubFactory(ResourceAttributeTypeFactory)
+    value = "Test attribute value"
+    resource = SubFactory(RAttributeTypeFactory)
+
+
 ### Allocation factories ###