Skip to content

Commit 9f88784

Browse files
Allow open split view using the keyboard (#19927)
* Allow open split view using the keyboard * Add localize method to the label * Add a method to localize terms with a language parameter * adjust localization wording * support segments in label * localize texts --------- Co-authored-by: Mads Rasmussen <[email protected]>
1 parent 1085eeb commit 9f88784

File tree

4 files changed

+17
-4
lines changed

4 files changed

+17
-4
lines changed

src/Umbraco.Web.UI.Client/src/assets/lang/da.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,9 @@ export default {
176176
confirmActionConfirm: 'Bekræft',
177177
morePublishingOptions: 'Flere publiseringsmuligheder',
178178
submitChanges: 'Indsæt',
179+
openInSplitView: 'Åbn i sidestillet visning',
180+
openVersionSelector: 'Åbn udgavevælger',
181+
closeVersionSelector: 'Luk udgavevælger',
179182
},
180183
auditTrailsMedia: {
181184
delete: 'Medie slettet',
@@ -352,6 +355,7 @@ export default {
352355
selectAllVariants: 'Vælg alle varianter',
353356
scheduledPendingChanges: 'Denne tidsplan har ændringer, der træder i kraft, når du klikker på "%0%".',
354357
noVariantsToProcess: 'Der er ingen tilgængelige varianter',
358+
openSplitViewForVariant: (variant: string) => `Åbn ${variant} i sidestillet visning`,
355359
},
356360
blueprints: {
357361
createBlueprintFrom: "Opret en ny indholdsskabelon fra '%0%'",

src/Umbraco.Web.UI.Client/src/assets/lang/en.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,9 @@ export default {
177177
morePublishingOptions: 'More publishing options',
178178
submitChanges: 'Submit',
179179
viewSystemDetails: 'View Umbraco CMS system information and version number',
180+
openInSplitView: 'Open in split view',
181+
openVersionSelector: 'Open version selector',
182+
closeVersionSelector: 'Close version selector',
180183
},
181184
auditTrailsMedia: {
182185
delete: 'Media deleted',
@@ -353,6 +356,7 @@ export default {
353356
saveModalTitle: 'Save',
354357
saveAndPublishModalTitle: 'Save and publish',
355358
publishModalTitle: 'Publish',
359+
openSplitViewForVariant: (variant: string) => `Open ${variant} in split view`,
356360
},
357361
blueprints: {
358362
createBlueprintFrom: "Create a new Document Blueprint from '%0%'",

src/Umbraco.Web.UI.Client/src/assets/lang/es.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ export default {
204204
removeTextBox: 'Eliminar caja de texto',
205205
contentRoot: 'Raíz de contenido',
206206
saveModalTitle: 'Guardar',
207+
openSplitViewForVariant: (variant: string) => `Abrir vista dividida para '${variant}'`,
207208
},
208209
blueprints: {
209210
createBlueprintFrom: 'Crear nueva Plantilla de Contenido desde <em>%0%</em>',

src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,9 @@ export class UmbWorkspaceSplitViewVariantSelectorElement<
324324
slot="append"
325325
popovertarget="popover"
326326
title=${this.#getVariantSpecInfo(this._activeVariant)}
327-
label="Select a variant">
327+
label=${this._variantSelectorOpen
328+
? this.localize.term('buttons_closeVersionSelector')
329+
: this.localize.term('buttons_openVersionSelector')}>
328330
${this.#getVariantSpecInfo(this._activeVariant)}
329331
${this.#renderReadOnlyTag(this._activeVariant?.culture)}
330332
<uui-symbol-expand .open=${this._variantSelectorOpen}></uui-symbol-expand>
@@ -488,9 +490,9 @@ export class UmbWorkspaceSplitViewVariantSelectorElement<
488490
: html`
489491
<uui-button
490492
class="split-view"
491-
label="Open Split view for ${variant.language.name}"
493+
label=${this.localize.term('content_openSplitViewForVariant', this.#getVariantSpecInfo(variant))}
492494
@click=${() => this.#openSplitView(variant)}>
493-
Open in Split view
495+
${this.localize.term('buttons_openInSplitView')}
494496
</uui-button>
495497
`}
496498
`;
@@ -561,7 +563,9 @@ export class UmbWorkspaceSplitViewVariantSelectorElement<
561563
background: none;
562564
}
563565
564-
.variant:hover > .split-view {
566+
.variant:hover > .split-view,
567+
.variant:focus > .split-view,
568+
.variant:focus-within > .split-view {
565569
display: flex;
566570
}
567571

0 commit comments

Comments
 (0)