Skip to content

Commit df9e39a

Browse files
committed
fix cyclic and self imports
1 parent 59aa15b commit df9e39a

File tree

53 files changed

+82
-92
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+82
-92
lines changed

src/libs/class-api/class.interface.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
1-
import type { UmbControllerHost } from '../controller-api/controller-host.interface.js';
2-
import type { UmbObserverController } from '../observable-api/index.js';
31
import type {
42
UmbContextCallback,
53
UmbContextConsumerController,
64
UmbContextProviderController,
75
UmbContextToken,
86
} from '../context-api/index.js';
7+
import type { UmbControllerHost, UmbController } from '@umbraco-cms/backoffice/controller-api';
8+
import type { UmbObserverController } from '@umbraco-cms/backoffice/observable-api';
99
import type { Observable } from '@umbraco-cms/backoffice/external/rxjs';
10-
import type { UmbController } from '@umbraco-cms/backoffice/controller-api';
1110

1211
export interface UmbClassMixinInterface extends UmbControllerHost, UmbController {
1312
observe<T>(

src/libs/class-api/controller-base.class.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { UmbController } from '../controller-api/controller.interface.js';
2-
import { UmbClassMixin } from './index.js';
2+
import { UmbClassMixin } from './class.mixin.js';
33

44
/**
55
* This mixin enables a web-component to host controllers.

src/libs/context-api/provide/context-provider.element.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
import type { UmbControllerHostElement} from '@umbraco-cms/backoffice/controller-api';
1+
import { UmbContextProviderController } from './context-provider.controller.js';
2+
import type { UmbControllerHostElement } from '@umbraco-cms/backoffice/controller-api';
23
import { UmbControllerHostElementMixin } from '@umbraco-cms/backoffice/controller-api';
34
import type { UmbContextToken } from '@umbraco-cms/backoffice/context-api';
4-
import { UmbContextProviderController } from '@umbraco-cms/backoffice/context-api';
55

6-
// TODO: There is some circular reference from this to Controller-api which is not good. We should move this elsewhere as we do not encourage the use of this element. Its only purpose is within Storybook and tests.
76
/**
87
* Provides a value to the context down the DOM tree.
98
*

src/libs/extension-api/controller/base-extension-initializer.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
import { createExtensionApi } from '../functions/index.js';
12
import type { UmbExtensionCondition } from '../condition/extension-condition.interface.js';
23
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
34
import { UmbBaseController } from '@umbraco-cms/backoffice/class-api';
4-
import { createExtensionApi } from '@umbraco-cms/backoffice/extension-api';
55
import type {
66
UmbConditionConfigBase,
77
ManifestCondition,

src/libs/extension-api/controller/extensions-element-initializer.controller.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1+
import type { ManifestBase } from '../types/index.js';
2+
import type { UmbExtensionRegistry } from '../registry/extension.registry.js';
13
import type { ManifestTypeMap, SpecificManifestTypeOrManifestBase } from '../types/map.types.js';
4+
import { UmbExtensionElementInitializer } from './extension-element-initializer.controller.js';
25
import {
36
type PermittedControllerType,
47
UmbBaseExtensionsInitializer,
58
} from './base-extensions-initializer.controller.js';
6-
import {
7-
type ManifestBase,
8-
UmbExtensionElementInitializer,
9-
type UmbExtensionRegistry,
10-
} from '@umbraco-cms/backoffice/extension-api';
119
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
1210

1311
/**

src/libs/observable-api/states/string-state.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { createObservablePart, type MappingFunction, type MemoizationFunction } from '../index.js';
1+
import type { MappingFunction, MemoizationFunction } from '../types/index.js';
2+
import { createObservablePart } from '../utils/index.js';
23
import { UmbBasicState } from './basic-state.js';
34

45
/**

src/packages/block/block-grid/property-editors/block-grid-editor/property-editor-ui-block-grid-inner-test.element.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class UmbPropertyEditorUIBlockGridInnerTestElement extends UmbLitElement
2222
{
2323
path: 'inner-1',
2424
component: () => {
25-
return import('./property-editor-ui-block-grid-inner-test.element.js');
25+
return new UmbPropertyEditorUIBlockGridInnerTestElement();
2626
},
2727
setup: (component) => {
2828
if (component instanceof HTMLElement) {
@@ -33,7 +33,7 @@ export class UmbPropertyEditorUIBlockGridInnerTestElement extends UmbLitElement
3333
{
3434
path: 'inner-2',
3535
component: () => {
36-
return import('./property-editor-ui-block-grid-inner-test.element.js');
36+
return new UmbPropertyEditorUIBlockGridInnerTestElement();
3737
},
3838
setup: (component) => {
3939
if (component instanceof HTMLElement) {

src/packages/core/collection/components/collection-selection-actions.element.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1+
import { UMB_DEFAULT_COLLECTION_CONTEXT } from '../default/collection-default.context.js';
12
import type { UmbActionExecutedEvent } from '@umbraco-cms/backoffice/event';
23
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
34
import { css, html, nothing, customElement, state } from '@umbraco-cms/backoffice/external/lit';
4-
import type { UmbDefaultCollectionContext } from '@umbraco-cms/backoffice/collection';
5-
import { UMB_DEFAULT_COLLECTION_CONTEXT } from '@umbraco-cms/backoffice/collection';
65
import { UmbLitElement } from '@umbraco-cms/internal/lit-element';
76

87
@customElement('umb-collection-selection-actions')
@@ -18,7 +17,7 @@ export class UmbCollectionSelectionActionsElement extends UmbLitElement {
1817

1918
private _selection: Array<string | null> = [];
2019

21-
private _collectionContext?: UmbDefaultCollectionContext<any, any>;
20+
private _collectionContext?: typeof UMB_DEFAULT_COLLECTION_CONTEXT.TYPE;
2221

2322
constructor() {
2423
super();

src/packages/core/collection/components/pagination/collection-pagination.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1+
import { UMB_DEFAULT_COLLECTION_CONTEXT } from '../../default/collection-default.context.js';
12
import type { UUIPaginationEvent } from '@umbraco-cms/backoffice/external/uui';
23
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
34
import { css, html, customElement, nothing, state } from '@umbraco-cms/backoffice/external/lit';
45
import type { UmbDefaultCollectionContext } from '@umbraco-cms/backoffice/collection';
5-
import { UMB_DEFAULT_COLLECTION_CONTEXT } from '@umbraco-cms/backoffice/collection';
66
import { UmbLitElement } from '@umbraco-cms/internal/lit-element';
77

88
@customElement('umb-collection-pagination')

src/packages/core/data-type/tree/folder/data-type-folder.repository.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { UMB_DATA_TYPE_FOLDER_ENTITY_TYPE } from '../../entity.js';
2-
import { UMB_DATA_TYPE_TREE_STORE_CONTEXT } from '../../tree/index.js';
2+
import { UMB_DATA_TYPE_TREE_STORE_CONTEXT } from '../data-type-tree.store.js';
33
import { UmbDataTypeFolderServerDataSource } from './data-type-folder.server.data-source.js';
44
import type { UmbDataTypeFolderTreeItemModel } from './types.js';
55
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';

0 commit comments

Comments
 (0)