Skip to content

Conversation

@madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Oct 24, 2024

Description

This PR introduces a UmbContentDetailWorkspaceBase class that can serve as the base for all our content-based entities: Document, Document Blueprint, Media, and Member.

The class has been implemented across all 4 entities.

Testing Instructions

  • Please perform some smoke testing by creating, deleting, and performing other operations on all of the content entities.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@nielslyngsoe
Copy link
Member

Hi @madsrasmussen I have been testing but there is some routing problem, might have to do with Discard Changes, when you try to create a new Document but already are on one.

Also it asks if you like to Discard Changes, thought none was made? — maybe we should have a look at why that happens as well.
image

@nielslyngsoe
Copy link
Member

Hi @madsrasmussen another problem appears when creating a new Document, this triggers a redirect from 'create' to 'edit'. which triggers a 'discard change'

@nielslyngsoe
Copy link
Member

And just to give you a whole picture right here at hand, then there is some circular dependency problem, as you can see in the tests :-)

@leekelleher leekelleher removed their request for review November 6, 2024 10:19
@madsrasmussen
Copy link
Contributor Author

might have to do with Discard Changes, when you try to create a new Document but already are on one.

This is fixed by: #2514

@nielslyngsoe nielslyngsoe merged commit e3c4177 into main Nov 7, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/feature/content-workspace-base branch November 7, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants