fix: failure function headers with context.call

Author: CahidArda

examples/ci/app/ci/constants.ts

@@ -67,5 +67,13 @@ export const TEST_ROUTES: Pick<TestConfig, "route" | "waitForSeconds">[] = [
   {
     route: "wait-for-event/workflow",
     waitForSeconds: 20
-  }
+  },
+  {
+    route: "call/workflow-with-failureFunction",
+    waitForSeconds: 5
+  },
+  {
+    route: "call/workflow-with-failureUrl",
+    waitForSeconds: 5
+  },
 ]

examples/ci/app/test-routes/call/workflow-with-failureFunction/route.ts

@@ -0,0 +1,46 @@
+import { serve } from "@upstash/workflow/nextjs";
+import { BASE_URL, TEST_ROUTE_PREFIX } from "app/ci/constants";
+import { testServe, expect } from "app/ci/utils";
+import { saveResult } from "app/ci/upstash/redis"
+import { FAILING_HEADER, FAILING_HEADER_VALUE } from "../constants";
+
+const testHeader = `test-header-foo`
+const headerValue = `header-foo`
+const payload = "my-payload"
+
+const thirdPartyEndpoint = `${TEST_ROUTE_PREFIX}/call/third-party`
+
+export const { POST, GET } = testServe(
+  serve<string>(
+    async (context) => {
+
+      const { body: patchResult, status, header } = await context.call("get call", {
+        url: thirdPartyEndpoint,
+        method: "PATCH",
+        retries: 0
+      });
+
+      expect(status, 401)
+      expect(patchResult as string, "failing request");
+      expect(header[FAILING_HEADER][0], FAILING_HEADER_VALUE)
+      
+      await saveResult(
+        context,
+        patchResult as string,
+      )
+    }, {
+      baseUrl: BASE_URL,
+      retries: 0,
+      failureFunction() {
+        console.log("SHOULDNT RUN");
+      },
+    }
+  ), {
+    expectedCallCount: 4,
+    expectedResult: "failing request",
+    payload,
+    headers: {
+      [ testHeader ]: headerValue,
+    }
+  }
+) 

examples/ci/app/test-routes/call/workflow-with-failureUrl/route.ts

@@ -0,0 +1,45 @@
+import { serve } from "@upstash/workflow/nextjs";
+import { BASE_URL, TEST_ROUTE_PREFIX } from "app/ci/constants";
+import { testServe, expect } from "app/ci/utils";
+import { saveResult } from "app/ci/upstash/redis"
+import { FAILING_HEADER, FAILING_HEADER_VALUE } from "../constants";
+
+const testHeader = `test-header-foo`
+const headerValue = `header-foo`
+const payload = "my-payload"
+
+const thirdPartyEndpoint = `${TEST_ROUTE_PREFIX}/call/third-party`
+
+export const { POST, GET } = testServe(
+  serve<string>(
+    async (context) => {
+
+      const { body: patchResult, status, header } = await context.call("get call", {
+        url: thirdPartyEndpoint,
+        method: "PATCH",
+        retries: 0
+      });
+
+      expect(status, 401)
+      expect(patchResult as string, "failing request");
+      expect(header[FAILING_HEADER][0], FAILING_HEADER_VALUE)
+      
+      await saveResult(
+        context,
+        patchResult as string,
+      )
+    }, {
+      baseUrl: BASE_URL,
+      retries: 0,
+      failureUrl: thirdPartyEndpoint
+      // failureUrl: `${TEST_ROUTE_PREFIX}/call/workflow-with-failureUrl`
+    }
+  ), {
+    expectedCallCount: 4,
+    expectedResult: "failing request",
+    payload,
+    headers: {
+      [ testHeader ]: headerValue,
+    }
+  }
+)

src/workflow-requests.ts

@@ -299,10 +299,10 @@ export const getHeaders = (
   }
 
   if (failureUrl) {
+    baseHeaders[`Upstash-Failure-Callback-Forward-${WORKFLOW_FAILURE_HEADER}`] = "true";
     if (!step?.callUrl) {
-      baseHeaders[`Upstash-Failure-Callback-Forward-${WORKFLOW_FAILURE_HEADER}`] = "true";
+      baseHeaders["Upstash-Failure-Callback"] = failureUrl;
     }
-    baseHeaders["Upstash-Failure-Callback"] = failureUrl;
   }
 
   // if retries is set or if call url is passed, set a retry