chore: remove i18n and sentry remote config (#6478)

### Description

This PR removes remote config for:
- allowOtaTranslations - this should be configured via the app config,
it seems unnecessary to remotely configure it given that it is a mature
feature now and unlikely needs to be switched off dynamically (an
equivalent action is to simply stop pushing OTA translations)
- sentryTracesSampleRate - we've never needed to change this value
- sentryNetworkErrors - we've never needed to change this value

Removing dynamic config for these allows us to simplify the
interdependencies of core dependencies, and the app init saga can work
more reliably.

### Test plan

n/a

### Related issues

- Related to RET-1272

### Backwards compatibility

Y

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [ ] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)

Author: kathaypacific

src/app/reducers.ts

@@ -25,8 +25,6 @@ interface State {
   // for the migration code. We can remove all the code associated with this after some time has passed.
   googleMobileServicesAvailable?: boolean
   huaweiMobileServicesAvailable?: boolean
-  sentryTracesSampleRate: number
-  sentryNetworkErrors: string[]
   supportedBiometryType: BIOMETRY_TYPE | null
   fiatConnectCashInEnabled: boolean
   fiatConnectCashOutEnabled: boolean
@@ -57,8 +55,6 @@ const initialState = {
   activeScreen: Screens.Main,
   googleMobileServicesAvailable: undefined,
   huaweiMobileServicesAvailable: undefined,
-  sentryTracesSampleRate: REMOTE_CONFIG_VALUES_DEFAULTS.sentryTracesSampleRate,
-  sentryNetworkErrors: REMOTE_CONFIG_VALUES_DEFAULTS.sentryNetworkErrors.split(','),
   supportedBiometryType: null,
   fiatConnectCashInEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.fiatConnectCashInEnabled,
   fiatConnectCashOutEnabled: REMOTE_CONFIG_VALUES_DEFAULTS.fiatConnectCashOutEnabled,
@@ -150,8 +146,6 @@ export const appReducer = (
     case Actions.UPDATE_REMOTE_CONFIG_VALUES:
       return {
         ...state,
-        sentryTracesSampleRate: action.configValues.sentryTracesSampleRate,
-        sentryNetworkErrors: action.configValues.sentryNetworkErrors,
         fiatConnectCashInEnabled: action.configValues.fiatConnectCashInEnabled,
         fiatConnectCashOutEnabled: action.configValues.fiatConnectCashOutEnabled,
       }

src/app/saga.test.ts

@@ -27,17 +27,12 @@ import {
   getLastTimeBackgrounded,
   getRequirePinOnAppOpen,
   inAppReviewLastInteractionTimestampSelector,
-  sentryNetworkErrorsSelector,
 } from 'src/app/selectors'
 import { DEEP_LINK_URL_SCHEME } from 'src/config'
 import { activeDappSelector } from 'src/dapps/selectors'
 import { FiatExchangeFlow } from 'src/fiatExchanges/types'
 import { initI18n } from 'src/i18n'
-import {
-  allowOtaTranslationsSelector,
-  currentLanguageSelector,
-  otaTranslationsAppVersionSelector,
-} from 'src/i18n/selectors'
+import { currentLanguageSelector, otaTranslationsAppVersionSelector } from 'src/i18n/selectors'
 import { jumpstartLinkHandler } from 'src/jumpstart/jumpstartLinkHandler'
 import { navigate } from 'src/navigator/NavigationService'
 import { Screens } from 'src/navigator/Screens'
@@ -548,10 +543,8 @@ describe('appInit', () => {
   })
 
   const defaultProviders: (EffectProviders | StaticProvider)[] = [
-    [select(allowOtaTranslationsSelector), true],
     [select(otaTranslationsAppVersionSelector), '1'],
     [select(currentLanguageSelector), 'nl-NL'],
-    [select(sentryNetworkErrorsSelector), ['network error']],
   ]
 
   it('should initialise the correct components, with the stored language', async () => {

src/app/saga.ts

@@ -10,14 +10,14 @@ import { AppEvents, InviteEvents } from 'src/analytics/Events'
 import { HooksEnablePreviewOrigin } from 'src/analytics/types'
 import {
   Actions,
-  OpenDeepLink,
-  OpenUrlAction,
-  SetAppState,
   androidMobileServicesAvailabilityChecked,
   appLock,
   inAppReviewRequested,
   inviteLinkConsumed,
+  OpenDeepLink,
   openDeepLink,
+  OpenUrlAction,
+  SetAppState,
   setAppState,
   setSupportedBiometryType,
   updateRemoteConfigValues,
@@ -28,18 +28,19 @@ import {
   googleMobileServicesAvailableSelector,
   huaweiMobileServicesAvailableSelector,
   inAppReviewLastInteractionTimestampSelector,
-  sentryNetworkErrorsSelector,
 } from 'src/app/selectors'
-import { DEFAULT_APP_LANGUAGE, FETCH_TIMEOUT_DURATION, isE2EEnv } from 'src/config'
+import {
+  DEFAULT_APP_LANGUAGE,
+  DEFAULT_SENTRY_NETWORK_ERRORS,
+  ENABLE_OTA_TRANSLATIONS,
+  FETCH_TIMEOUT_DURATION,
+  isE2EEnv,
+} from 'src/config'
 import { FiatExchangeFlow } from 'src/fiatExchanges/types'
 import { FiatAccountSchemaCountryOverrides } from 'src/fiatconnect/types'
 import { fetchRemoteConfigValues } from 'src/firebase/firebase'
 import { initI18n } from 'src/i18n'
-import {
-  allowOtaTranslationsSelector,
-  currentLanguageSelector,
-  otaTranslationsAppVersionSelector,
-} from 'src/i18n/selectors'
+import { currentLanguageSelector, otaTranslationsAppVersionSelector } from 'src/i18n/selectors'
 import { jumpstartClaim } from 'src/jumpstart/saga'
 import { navigate, navigateHome } from 'src/navigator/NavigationService'
 import { Screens } from 'src/navigator/Screens'
@@ -97,15 +98,16 @@ const REVIEW_INTERVAL = ONE_DAY_IN_MILLIS * 120 // 120 days
 // Work that's done before other sagas are initalized
 // Be mindful to not put long blocking tasks here
 export function* appInit() {
+  yield* call(initializeSentry)
+
   SentryTransactionHub.startTransaction(SentryTransaction.app_init_saga)
 
-  const allowOtaTranslations = yield* select(allowOtaTranslationsSelector)
   const otaTranslationsAppVersion = yield* select(otaTranslationsAppVersionSelector)
   const language = yield* select(currentLanguageSelector)
   const bestLanguage = findBestLanguageTag(Object.keys(locales))?.languageTag
+  const allowOtaTranslations = ENABLE_OTA_TRANSLATIONS
 
   yield* all([
-    call(initializeSentry),
     call([AppAnalytics, 'init']),
     call(
       initI18n,
@@ -115,10 +117,7 @@ export function* appInit() {
     ),
   ])
 
-  // This step is important if the user is offline and unable to fetch remote
-  // config values, we can use the persisted value instead of an empty one
-  const sentryNetworkErrors = yield* select(sentryNetworkErrorsSelector)
-  Logger.setNetworkErrors(sentryNetworkErrors)
+  Logger.setNetworkErrors(DEFAULT_SENTRY_NETWORK_ERRORS)
 
   const supportedBiometryType = yield* call(Keychain.getSupportedBiometryType)
   yield* put(setSupportedBiometryType(supportedBiometryType))
@@ -176,9 +175,6 @@ export function* checkAndroidMobileServicesSaga() {
 
 export interface RemoteConfigValues {
   inviteRewardsVersion: string
-  allowOtaTranslations: boolean
-  sentryTracesSampleRate: number
-  sentryNetworkErrors: string[]
   fiatConnectCashInEnabled: boolean
   fiatConnectCashOutEnabled: boolean
   fiatAccountSchemaCountryOverrides: FiatAccountSchemaCountryOverrides
@@ -202,7 +198,6 @@ export function* appRemoteFeatureFlagSaga() {
         timeout: delay(FETCH_TIMEOUT_DURATION),
       })
       if (configValues) {
-        Logger.setNetworkErrors(configValues.sentryNetworkErrors)
         yield* put(updateRemoteConfigValues(configValues))
         lastLoadTime = Date.now()
       }

src/app/selectors.ts

@@ -30,10 +30,6 @@ export const googleMobileServicesAvailableSelector = (state: RootState) =>
 export const huaweiMobileServicesAvailableSelector = (state: RootState) =>
   state.app.huaweiMobileServicesAvailable
 
-export const sentryTracesSampleRateSelector = (state: RootState) => state.app.sentryTracesSampleRate
-
-export const sentryNetworkErrorsSelector = (state: RootState) => state.app.sentryNetworkErrors
-
 export const supportedBiometryTypeSelector = (state: RootState) => state.app.supportedBiometryType
 
 export const fiatConnectCashInEnabledSelector = (state: RootState) =>

src/config.ts

@@ -161,6 +161,7 @@ export const SIMPLEX_FEES_URL =
 
 export const APP_STORE_ID = Config.APP_STORE_ID
 export const DYNAMIC_LINK_DOMAIN_URI_PREFIX = 'https://vlra.app'
+export const ENABLE_OTA_TRANSLATIONS = true
 export const CROWDIN_DISTRIBUTION_HASH = 'e-f9f6869461793b9d1a353b2v7c'
 export const OTA_TRANSLATIONS_FILEPATH = `file://${CachesDirectoryPath}/translations`
 

src/firebase/firebase.ts

@@ -274,9 +274,6 @@ export async function fetchRemoteConfigValues(): Promise<RemoteConfigValues | nu
 
   return {
     inviteRewardsVersion: flags.inviteRewardsVersion.asString(),
-    allowOtaTranslations: flags.allowOtaTranslations.asBoolean(),
-    sentryTracesSampleRate: flags.sentryTracesSampleRate.asNumber(),
-    sentryNetworkErrors: flags.sentryNetworkErrors.asString().split(','),
     fiatConnectCashInEnabled: flags.fiatConnectCashInEnabled.asBoolean(),
     fiatConnectCashOutEnabled: flags.fiatConnectCashOutEnabled.asBoolean(),
     fiatAccountSchemaCountryOverrides: fiatAccountSchemaCountryOverrides

src/firebase/remoteConfigValuesDefaults.e2e.ts

@@ -2,14 +2,9 @@ import { RemoteConfigValues } from 'src/app/saga'
 
 export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   RemoteConfigValues,
-  'sentryNetworkErrors' | 'fiatAccountSchemaCountryOverrides'
-> & {
-  sentryNetworkErrors: string
-} = {
+  'fiatAccountSchemaCountryOverrides'
+> = {
   inviteRewardsVersion: 'none',
-  allowOtaTranslations: false,
-  sentryTracesSampleRate: 0.2,
-  sentryNetworkErrors: '',
   fiatConnectCashInEnabled: false,
   fiatConnectCashOutEnabled: true,
 }

src/firebase/remoteConfigValuesDefaults.ts

@@ -1,16 +1,10 @@
 import { RemoteConfigValues } from 'src/app/saga'
-import { DEFAULT_SENTRY_NETWORK_ERRORS, DEFAULT_SENTRY_TRACES_SAMPLE_RATE } from 'src/config'
 
 export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   RemoteConfigValues,
-  'sentryNetworkErrors' | 'fiatAccountSchemaCountryOverrides'
-> & {
-  sentryNetworkErrors: string
-} = {
+  'fiatAccountSchemaCountryOverrides'
+> = {
   inviteRewardsVersion: 'none',
-  allowOtaTranslations: false,
-  sentryTracesSampleRate: DEFAULT_SENTRY_TRACES_SAMPLE_RATE,
-  sentryNetworkErrors: DEFAULT_SENTRY_NETWORK_ERRORS.join(','),
   fiatConnectCashInEnabled: false,
   fiatConnectCashOutEnabled: false,
 }

src/i18n/index.ts

@@ -2,8 +2,8 @@ import hoistStatics from 'hoist-non-react-statics'
 import i18n, { Resource, ResourceLanguage } from 'i18next'
 import _ from 'lodash'
 import {
-  WithTranslation,
   initReactI18next,
+  WithTranslation,
   withTranslation as withTranslationI18Next,
 } from 'react-i18next'
 import DeviceInfo from 'react-native-device-info'

src/i18n/saga.test.ts

@@ -6,7 +6,6 @@ import { call, select } from 'redux-saga/effects'
 import { saveOtaTranslations } from 'src/i18n/otaTranslations'
 import { handleFetchOtaTranslations } from 'src/i18n/saga'
 import {
-  allowOtaTranslationsSelector,
   currentLanguageSelector,
   otaTranslationsAppVersionSelector,
   otaTranslationsLanguageSelector,
@@ -44,7 +43,6 @@ describe('i18n sagas', () => {
     const mockedVersion = DeviceInfo.getVersion as jest.MockedFunction<typeof DeviceInfo.getVersion>
     mockedVersion.mockImplementation(() => appVersion)
     const defaultProviders: (EffectProviders | StaticProvider)[] = [
-      [select(allowOtaTranslationsSelector), true],
       [select(otaTranslationsAppVersionSelector), appVersion],
       [select(otaTranslationsLanguageSelector), 'en-US'],
       [select(currentLanguageSelector), 'en-US'],