From 80ca3958479ae96036d22a60ebba13ee71296646 Mon Sep 17 00:00:00 2001 From: Leticia Costa Fernandes Date: Tue, 9 Feb 2021 14:03:54 -0300 Subject: [PATCH 1/4] feat(cue): set automatic value for line and position to be -1 --- lib/parser/parse-cue.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/parser/parse-cue.js b/lib/parser/parse-cue.js index 53b828a1..d7541be4 100644 --- a/lib/parser/parse-cue.js +++ b/lib/parser/parse-cue.js @@ -66,7 +66,7 @@ function parseCue(input, cue, regionList) { cue.region = settings.get("region", null); cue.vertical = settings.get("vertical", ""); try { - cue.line = settings.get("line", "auto"); + cue.line = settings.get("line", -1); } catch (e) { // eslint-ignore-line } @@ -80,7 +80,7 @@ function parseCue(input, cue, regionList) { cue.align = settings.get("align", "middle"); } try { - cue.position = settings.get("position", "auto"); + cue.position = settings.get("position", -1); } catch (e) { cue.position = settings.get("position", { start: 0, From 428c5f687a8feaa9ea00f8ea0a1b80834ce5e759 Mon Sep 17 00:00:00 2001 From: Leticia Costa Fernandes Date: Tue, 9 Feb 2021 14:24:33 -0300 Subject: [PATCH 2/4] 0.15.3 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index b22e0f7a..39f63263 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "videojs-vtt.js", - "version": "0.15.2", + "version": "0.15.3", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index f91f0bda..b1e8defa 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ ], "name": "videojs-vtt.js", "description": "A JavaScript implementation of the WebVTT specification, forked from vtt.js for use with Video.js", - "version": "0.15.2", + "version": "0.15.3", "main": "lib/browser-index.js", "repository": { "type": "git", From 998030202d1c3bfeb5705aa19b3271dd9dea708f Mon Sep 17 00:00:00 2001 From: Leticia Costa Fernandes Date: Tue, 9 Feb 2021 16:18:08 -0300 Subject: [PATCH 3/4] fix(parse-cue): set fallback value -1 for line/position properties if web engine converts auto to 0 some TV Web Engines (for example WebOS 3 - Chromium 38) does not support string values for line/position properties only numeric --- lib/parser/parse-cue.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/parser/parse-cue.js b/lib/parser/parse-cue.js index d7541be4..bb612a74 100644 --- a/lib/parser/parse-cue.js +++ b/lib/parser/parse-cue.js @@ -66,7 +66,9 @@ function parseCue(input, cue, regionList) { cue.region = settings.get("region", null); cue.vertical = settings.get("vertical", ""); try { - cue.line = settings.get("line", -1); + cue.line = settings.get("line", "auto"); + /** Set -1 as default value to contemplate scenarios where the Web Engine does not support the string auto and converts it to 0 */ + if (settings.get("line") === undefined && cue.line != "auto") { cue.line = settings.get("line", -1) }; } catch (e) { // eslint-ignore-line } @@ -80,7 +82,9 @@ function parseCue(input, cue, regionList) { cue.align = settings.get("align", "middle"); } try { - cue.position = settings.get("position", -1); + cue.position = settings.get("position", "auto"); + /** Set -1 as default value to contemplate scenarios where the Web Engine does not support the string auto and converts it to 0 */ + if (settings.get("position") === undefined && cue.line != "auto") { cue.position = settings.get("position", -1) }; } catch (e) { cue.position = settings.get("position", { start: 0, From 4ac10c58cdadc2125dfaa3273c9b2bba9ff9fba7 Mon Sep 17 00:00:00 2001 From: Leticia Costa Fernandes Date: Tue, 9 Feb 2021 16:18:15 -0300 Subject: [PATCH 4/4] 0.15.4 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 39f63263..da8e9352 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "videojs-vtt.js", - "version": "0.15.3", + "version": "0.15.4", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index b1e8defa..21b0e81e 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ ], "name": "videojs-vtt.js", "description": "A JavaScript implementation of the WebVTT specification, forked from vtt.js for use with Video.js", - "version": "0.15.3", + "version": "0.15.4", "main": "lib/browser-index.js", "repository": { "type": "git",