Skip to content

Commit 33a3706

Browse files
author
Vinit Kumar
authored
refactor: xmltodict is only test dependency (#124)
1 parent 6aafca8 commit 33a3706

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

.github/workflows/pythonpackage.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,11 @@ jobs:
3030
python -m pip install --upgrade pip
3131
pip install pytest
3232
pip install -r requirements.txt
33-
python setup.py install
34-
- name: Lint with flake8
35-
run: |
36-
pip install flake8
3733
pip install xmltodict==0.12.0
3834
pip install pytest==7.0.1
3935
pip install coverage==6.3.2
4036
pip install py==1.11.0
41-
# stop the build if there are Python syntax errors or undefined names
42-
flake8 json2xml/ --exit-zero
37+
python setup.py install
4338
- name: Unit tests
4439
run: |
4540
coverage run -m pytest

README.rst

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,10 @@ This is provided by pytest, which is straight forward.
197197

198198
.. code-block:: bash
199199
200-
python3.8 -mvenv venv
201-
source venv/bin/activate
202-
python setup.py test
200+
virtualenv venv -p $(which python3.9)
201+
pip install -r requirements-dev.txt
202+
python setup.py install
203+
pytest
203204
204205
205206
Credits

requirements-dev.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
-r requirements.txt
2+
xmltodict==0.12.0
3+
pytest==7.0.1
4+
coverage==6.3.2
5+
py==1.11.0

requirements.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
requests>=2.20.0
22
defusedxml==0.7.1
3-
xmltodict
43

requirements.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,3 @@ requests==2.26.0
1616
# via -r requirements.in
1717
urllib3==1.26.7
1818
# via requests
19-
xmltodict==0.12.0
20-
# via -r requirements.in

0 commit comments

Comments
 (0)