Skip to content

Commit 0305853

Browse files
committed
refactor imports to prevent circular import
1 parent a75067d commit 0305853

File tree

7 files changed

+14
-28
lines changed

7 files changed

+14
-28
lines changed

examples/fv_solver_workflow.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import os
22
from pathlib import Path
33

4-
from pyvcell.data_model import SbmlSpatialModel, SbmlSpatialSimulation
4+
from pyvcell.data_model.sbml_spatial_model import SbmlSpatialModel
5+
from pyvcell.data_model.simulation import SbmlSpatialSimulation
56

67
model_fp = Path(os.getcwd()) / "solver_input" / "SmallSpacialProject_3D.xml"
78

pyvcell/data_model/__init__.py

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +0,0 @@
1-
from pyvcell.data_model.plotter import Plotter
2-
from pyvcell.data_model.result import Result
3-
from pyvcell.data_model.sbml_spatial_model import SbmlSpatialModel
4-
from pyvcell.data_model.simulation import SbmlSpatialSimulation, VcmlSpatialSimulation
5-
from pyvcell.data_model.var_types import NDArray1D, NDArray2D, NDArray3D
6-
from pyvcell.data_model.vcml_spatial_model import VcmlSpatialModel
7-
from pyvcell.data_model.vtk_data import VtkData
8-
from pyvcell.data_model.zarr_types import Channel
9-
10-
__all__ = [
11-
"Plotter",
12-
"Result",
13-
"SbmlSpatialModel",
14-
"SbmlSpatialSimulation",
15-
"VcmlSpatialSimulation",
16-
"VcmlSpatialModel",
17-
"VtkData",
18-
"Channel",
19-
"NDArray1D",
20-
"NDArray2D",
21-
"NDArray3D",
22-
]

tests/data_model/test_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from pathlib import Path
22

3-
from pyvcell.data_model import SbmlSpatialModel
3+
from pyvcell.data_model.sbml_spatial_model import SbmlSpatialModel
44

55

66
def test_sbml_model_parse_1d(sbml_spatial_model_1d_path: Path) -> None:

tests/data_model/test_result.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
import numpy as np
66
import pytest
77

8-
from pyvcell.data_model import NDArray2D, Result
8+
from pyvcell.data_model.result import Result
9+
from pyvcell.data_model.var_types import NDArray2D
910

1011
IN_GITHUB_ACTIONS = os.getenv("GITHUB_ACTIONS") == "true"
1112

tests/data_model/test_simulations.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
import numpy as np
44

55
import pyvcell.vcml as vc
6-
from pyvcell.data_model import Result, SbmlSpatialModel, SbmlSpatialSimulation, VcmlSpatialModel, VcmlSpatialSimulation
6+
from pyvcell.data_model.result import Result
7+
from pyvcell.data_model.sbml_spatial_model import SbmlSpatialModel
8+
from pyvcell.data_model.simulation import SbmlSpatialSimulation, VcmlSpatialSimulation
9+
from pyvcell.data_model.vcml_spatial_model import VcmlSpatialModel
710

811

912
def test_sbml_model_parse_1d(sbml_spatial_model_1d_path: Path) -> None:

tests/simdata/test_vtk.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
import pytest
55
import pyvista
66

7-
from pyvcell.data_model import NDArray1D, Result
7+
from pyvcell.data_model.result import Result
8+
from pyvcell.data_model.var_types import NDArray1D
89
from pyvcell.simdata.mesh import CartesianMesh
910
from pyvcell.simdata.vtk.fv_mesh_mapping import from_mesh_data
1011
from pyvcell.simdata.vtk.vismesh import FiniteVolumeIndex, FiniteVolumeIndexData, VisMesh

tests/vcml/test_creation.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
from pathlib import Path
22

33
import pyvcell.vcml as vc
4-
from pyvcell.data_model import Result, VcmlSpatialModel, VcmlSpatialSimulation
4+
from pyvcell.data_model.result import Result
5+
from pyvcell.data_model.simulation import VcmlSpatialSimulation
6+
from pyvcell.data_model.vcml_spatial_model import VcmlSpatialModel
57

68

79
def test_create() -> None:

0 commit comments

Comments
 (0)