fix: wrap model instantiation in expect closure for exception tests

The exception is thrown during model initialization (when using the trait),
not during the create() call. This fix wraps the entire model class creation
inside the expect closure so the exception can be properly caught.

Co-authored-by: Vladislav Stoitsov <[email protected]>

Author: github-actions[bot]

tests/HasUniqueUrlsTest.php

@@ -181,30 +181,32 @@
     });
 
     // Create a model class that uses HasUniqueUrls trait
-    $modelClass = new class () extends \Illuminate\Database\Eloquent\Model {
-        use \Vlados\LaravelUniqueUrls\HasUniqueUrls;
-
-        protected $table = 'models_with_url_column';
-        protected $guarded = [];
-        public $timestamps = false;
-
-        public function urlHandler(): array
-        {
-            return [
-                'controller' => \Vlados\LaravelUniqueUrls\Tests\TestUrlHandler::class,
-                'method' => 'view',
-                'arguments' => [],
-            ];
-        }
+    // The exception should be thrown during model instantiation
+    expect(function () {
+        $modelClass = new class () extends \Illuminate\Database\Eloquent\Model {
+            use \Vlados\LaravelUniqueUrls\HasUniqueUrls;
+
+            protected $table = 'models_with_url_column';
+            protected $guarded = [];
+            public $timestamps = false;
+
+            public function urlHandler(): array
+            {
+                return [
+                    'controller' => \Vlados\LaravelUniqueUrls\Tests\TestUrlHandler::class,
+                    'method' => 'view',
+                    'arguments' => [],
+                ];
+            }
 
-        public function urlStrategy($language, $locale): string
-        {
-            return \Illuminate\Support\Str::slug($this->name);
-        }
-    };
+            public function urlStrategy($language, $locale): string
+            {
+                return \Illuminate\Support\Str::slug($this->name);
+            }
+        };
 
-    expect(fn () => $modelClass::create(['name' => 'test', 'url' => 'test-url']))
-        ->toThrow(Exception::class, "has a conflicting column 'url'");
+        $modelClass::create(['name' => 'test', 'url' => 'test-url']);
+    })->toThrow(Exception::class, "has a conflicting column 'url'");
 
     Schema::dropIfExists('models_with_url_column');
 });
@@ -218,30 +220,32 @@ public function urlStrategy($language, $locale): string
     });
 
     // Create a model class that uses HasUniqueUrls trait
-    $modelClass = new class () extends \Illuminate\Database\Eloquent\Model {
-        use \Vlados\LaravelUniqueUrls\HasUniqueUrls;
-
-        protected $table = 'models_with_urls_column';
-        protected $guarded = [];
-        public $timestamps = false;
-
-        public function urlHandler(): array
-        {
-            return [
-                'controller' => \Vlados\LaravelUniqueUrls\Tests\TestUrlHandler::class,
-                'method' => 'view',
-                'arguments' => [],
-            ];
-        }
+    // The exception should be thrown during model instantiation
+    expect(function () {
+        $modelClass = new class () extends \Illuminate\Database\Eloquent\Model {
+            use \Vlados\LaravelUniqueUrls\HasUniqueUrls;
+
+            protected $table = 'models_with_urls_column';
+            protected $guarded = [];
+            public $timestamps = false;
+
+            public function urlHandler(): array
+            {
+                return [
+                    'controller' => \Vlados\LaravelUniqueUrls\Tests\TestUrlHandler::class,
+                    'method' => 'view',
+                    'arguments' => [],
+                ];
+            }
 
-        public function urlStrategy($language, $locale): string
-        {
-            return \Illuminate\Support\Str::slug($this->name);
-        }
-    };
+            public function urlStrategy($language, $locale): string
+            {
+                return \Illuminate\Support\Str::slug($this->name);
+            }
+        };
 
-    expect(fn () => $modelClass::create(['name' => 'test', 'urls' => 'test-urls']))
-        ->toThrow(Exception::class, "has a conflicting column 'urls'");
+        $modelClass::create(['name' => 'test', 'urls' => 'test-urls']);
+    })->toThrow(Exception::class, "has a conflicting column 'urls'");
 
     Schema::dropIfExists('models_with_urls_column');
 });