allow reloading config instead of restarting to reload it #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
requested changes
Nov 3, 2022
manifests/init.pp
Outdated
| Boolean $trap_service_enable = false, | ||
| Boolean $trap_service_hasstatus = true, | ||
| Boolean $trap_service_hasrestart = true, | ||
| String[1] $service_restart = "/bin/systemctl reload $service_name", |
There was a problem hiding this comment.
Suggested change
| String[1] $service_restart = "/bin/systemctl reload $service_name", | |
| String[1] $service_restart = "/bin/systemctl reload ${service_name}", |
There was a problem hiding this comment.
Also this will break (at least) FreeBSD support. This parameter should probably be optional, default to undef and set to this value only on systems where it makes sense through Hiera.
Co-authored-by: Kenyon Ralph <[email protected]>
|
thanks @kenyon, I implemented your suggestion now. |
|
Also need to implement @smortex's suggestion I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow the use of reload instead of restart as it causes false reboot events in Solarwinds Orion.
This Pull Request (PR) fixes the following issues
Fixes #264