Restore expiry/deletion logic

Author: apasel422

impl/src/backend.ts

@@ -718,42 +718,43 @@ export class Backend {
     return startEpoch;
   }
 
-  clearImpressionsForConversionSite(site: string): void {
-    void site;
-    /* TODO
-    function shouldRemoveImpression(i: Impression): boolean {
+  async clearImpressionsForConversionSite(site: string): Promise<void> {
+    const db = await this.#getOrCreateDB();
+    const txn = db.transaction("impressions", "readwrite");
+
+    for await (const cursor of txn.store) {
+      const i = cursor.value;
+
       if (i.intermediarySite === site) {
-        return true;
+        await cursor.delete();
+        continue;
       }
       if (!i.conversionSites.has(site)) {
-        return false;
+        continue;
       }
       if (i.conversionSites.size > 1) {
         i.conversionSites.delete(site);
-        return false;
+        await cursor.update(i);
+        continue;
       }
-      return true;
+      await cursor.delete();
     }
-
-    this.#impressions = this.#impressions.filter(
-      (i) => !shouldRemoveImpression(i),
-    );
-    */
   }
 
-  clearExpiredImpressions(): void {
-    /* TODO
+  async clearExpiredImpressions(): Promise<void> {
+    const db = await this.#getOrCreateDB();
+    const txn = db.transaction("impressions", "readwrite");
+
     const now = this.#delegate.now();
 
-    this.#impressions = this.#impressions.filter((impression) => {
-      return (
-        Temporal.Instant.compare(
-          now,
-          impression.timestamp.add(impression.lifetime),
-        ) < 0
-      );
-    });
-    */
+    for await (const cursor of txn.store.iterate()) {
+      const i = cursor.value;
+      const expiry = i.timestamp.toTemporalInstant().add(days(i.lifetimeDays));
+
+      if (Temporal.Instant.compare(now, expiry) > 0) {
+        await cursor.delete();
+      }
+    }
   }
 
   #fairlyAllocateCredit(credit: number[], value: number): number[] {

impl/src/simulator.ts

@@ -125,8 +125,7 @@ async function updateImpressionsTable() {
 
     now = now.add(days(daysInput.valueAsNumber));
     time.innerText = now.toString();
-    backend.clearExpiredImpressions();
-    void updateImpressionsTable();
+    void backend.clearExpiredImpressions().then(updateImpressionsTable);
   });
 }